This is an archive of the discontinued LLVM Phabricator instance.

[fuchsia] Tune PrimaryGroupSizeLog to reduce fragmentation.
ClosedPublic

Authored by supersymetrie on Dec 19 2022, 9:07 AM.

Details

Summary

21U is the default group size, which demonstrates ~15mb reduction
in heap size for some highly fragmented heaps on Fuchsia, and
a general 5mb savings when devices are under no load.

Microbenchmarks show no performance regressions, but most of our
benchmarks perform no significant mallocs. So we are choosing the
default setting, and monitoring for potential performance
issues.

Diff Detail

Event Timeline

supersymetrie created this revision.Dec 19 2022, 9:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 9:07 AM
supersymetrie requested review of this revision.Dec 19 2022, 9:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 9:07 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

After speaking with Android scudo maintainters, they feel
that 128mb primary group size is more conservative than need be,
and the default size should be sufficient.

supersymetrie edited the summary of this revision. (Show Details)Dec 19 2022, 9:28 AM
Chia-hungDuan accepted this revision.Dec 19 2022, 10:15 AM
This revision is now accepted and ready to land.Dec 19 2022, 10:15 AM