This is an archive of the discontinued LLVM Phabricator instance.

[lit] Fix a few issues in relative_lines.py
ClosedPublic

Authored by hokein on Dec 19 2022, 6:16 AM.

Details

Summary
  • fixes error: Line: 91 result += contents[pos:m.start(index)] TypeError: can only concatenate str (not "bytes") to str
  • fixes the "-code-completion-at=%s:%(lineb'-7')" rewritten results

Diff Detail

Event Timeline

hokein created this revision.Dec 19 2022, 6:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 6:16 AM
hokein requested review of this revision.Dec 19 2022, 6:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 6:16 AM
sammccall accepted this revision.Dec 19 2022, 6:40 AM

thank you!
I guess I tested this only on files with no matches/bad utf-8 :-(

This revision is now accepted and ready to land.Dec 19 2022, 6:40 AM
This revision was landed with ongoing or failed builds.Dec 19 2022, 10:58 AM
This revision was automatically updated to reflect the committed changes.