This is an archive of the discontinued LLVM Phabricator instance.

[InlineAdvisor] Fix dependencies for InlineAdvisorPlugin
ClosedPublic

Authored by IBricchi on Dec 17 2022, 3:33 PM.

Download Raw Diff

Details

Reviewers

mtrofin
akyrtzi

Commits

rGc365fdd8d53c: [InlineAdvisor] Fix dependencies for InlineAdvisorPlugin

Summary

This patch should address the build failures from:
07af0e2d3e8485ad6f84da1ad9851538b62d2942

Adds intrinsics_gen as a dependancy of the plugin.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

IBricchi created this revision.Dec 17 2022, 3:33 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2022, 3:33 PM

IBricchi requested review of this revision.Dec 17 2022, 3:33 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2022, 3:33 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

IBricchi set the repository for this revision to rG LLVM Github Monorepo.Dec 17 2022, 3:33 PM

IBricchi mentioned this in D139644: [InlineAdvisor] Allow loading advisors as plugins.

Change LGTM, could you get this in soon? 🙏

This revision is now accepted and ready to land.Dec 17 2022, 4:06 PM

Harbormaster completed remote builds in B203783: Diff 483785.Dec 17 2022, 5:46 PM

I don'ţhave commit access to llvm, so if you could commit it for me @akyrtzi that would be great.

Last time someone asked me for author: (ibricchi) and email: (ibricchi@student.ethz.ch)

Closed by commit rGc365fdd8d53c: [InlineAdvisor] Fix dependencies for InlineAdvisorPlugin (authored by IBricchi, committed by akyrtzi). · Explain WhyDec 18 2022, 1:26 AM

This revision was automatically updated to reflect the committed changes.

akyrtzi added a commit: rGc365fdd8d53c: [InlineAdvisor] Fix dependencies for InlineAdvisorPlugin.

Committed, thank you for the quick fix! 🙇🏻‍♂️

Revision Contents

Path

Size

llvm/

unittests/

Analysis/

CMakeLists.txt

4 lines

Diff 483805

llvm/unittests/Analysis/CMakeLists.txt

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines	if (NOT WIN32)
# Put PLUGIN next to the unit test executable.		# Put PLUGIN next to the unit test executable.
set_output_directory(InlineAdvisorPlugin		set_output_directory(InlineAdvisorPlugin
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}		BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}		LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
)		)
set_target_properties(InlineAdvisorPlugin PROPERTIES FOLDER "Tests")		set_target_properties(InlineAdvisorPlugin PROPERTIES FOLDER "Tests")

export_executable_symbols_for_plugins(AnalysisTests)		export_executable_symbols_for_plugins(AnalysisTests)
# The plugin depends on some of the output files of llvm-tblgen, so make sure		# The plugin depends on some of the output files of intrinsics_gen, so make sure
# it is built before the plugin.		# it is built before the plugin.
add_dependencies(InlineAdvisorPlugin llvm-tblgen)		add_dependencies(InlineAdvisorPlugin intrinsics_gen)
add_dependencies(AnalysisTests InlineAdvisorPlugin)		add_dependencies(AnalysisTests InlineAdvisorPlugin)
set_property(TARGET InlineAdvisorPlugin PROPERTY FOLDER "Tests/UnitTests/AnalysisTests")		set_property(TARGET InlineAdvisorPlugin PROPERTY FOLDER "Tests/UnitTests/AnalysisTests")
endif()		endif()