[flang] Check C854, C855, & C856 on PROTECTED entities

[klausler]

Summary

Check for things that are not allowed to bear the PROTECTED
attribute.

[PeteSteinfeld]

All builds and tests correctly and looks good.

flang/lib/Semantics/check-declarations.cpp

common::visit(
       symbol.details());
   if (symbol.attrs().test(Attr::VOLATILE)) {
     CheckVolatile(symbol, derived);
   }
   CheckBindC(symbol);
   if (isDone) {
     return; // following checks do not apply
   }
+  if (symbol.attrs().test(Attr::PROTECTED)) {
+    if (symbol.owner().kind() != Scope::Kind::Module) { // C854
+      messages_.Say(
+          "A PROTECTED entity must be in the specification part of a module"_err_en_US);
+    }
+    if (!evaluate::IsVariable(symbol) && !IsProcedurePointer(symbol)) { // C855
+      messages_.Say(
+          "A PROTECTED entity must be a variable or pointer"_err_en_US);
+    }
+    if (InCommonBlock(symbol)) { // C856
+      messages_.Say(
+          "A PROTECTED entity may not be in a common block"_err_en_US);
+    }
+  }
   if (IsPointer(symbol)) {
     CheckPointer(symbol);
   }
   if (InPure()) {
     if (InInterface()) {
       // Declarations in interface definitions "have no effect" if they
       // are not pertinent to the characteristics of the procedure.
       // Restrictions on entities in pure procedure interfaces don't need

flang/test/Semantics/resolve82.f90

module m
   procedure(procFunc), public, pointer, public :: proc1
   !WARNING: Attribute 'PRIVATE' cannot be used more than once
   procedure(procFunc), private, pointer, private :: proc2
   !WARNING: Attribute 'BIND(C)' cannot be used more than once
   !ERROR: An interface name with BIND attribute must be specified if the BIND attribute is specified in a procedure declaration statement
   procedure(procFunc), bind(c), pointer, bind(c) :: proc3
   !WARNING: Attribute 'PROTECTED' cannot be used more than once
   procedure(procFunc), protected, pointer, protected :: proc4
+  !ERROR: A PROTECTED entity must be a variable or pointer
+  external extsub
+  protected extsub
+  real x
+  !ERROR: A PROTECTED entity must be a variable or pointer
+  namelist /nml/ x
+  protected nml
+  !ERROR: A PROTECTED entity may not be in a common block
+  real y
+  common /blk/ y
+  protected y
 
 contains
 
     subroutine testProcDecl(arg4, arg5, arg6, arg7, arg8, arg9, arg10, arg11)
       !WARNING: Attribute 'INTENT(IN)' cannot be used more than once
       procedure(procFunc), intent(in), pointer, intent(in) :: arg4
       !WARNING: Attribute 'INTENT(OUT)' cannot be used more than once
       procedure(procFunc), intent(out), pointer, intent(out) :: arg5
       !WARNING: Attribute 'INTENT(INOUT)' cannot be used more than once
       procedure(procFunc), intent(inout), pointer, intent(inout) :: arg6
       !ERROR: Attributes 'INTENT(INOUT)' and 'INTENT(OUT)' conflict with each other
       procedure(procFunc), intent(inout), pointer, intent(out) :: arg7
       !ERROR: Attributes 'INTENT(INOUT)' and 'INTENT(OUT)' conflict with each other
       procedure(procFunc), intent(out), pointer, intent(inout) :: arg8
       !WARNING: Attribute 'OPTIONAL' cannot be used more than once
       procedure(procFunc), optional, pointer, optional :: arg9
       !WARNING: Attribute 'POINTER' cannot be used more than once
       procedure(procFunc), pointer, optional, pointer :: arg10
       !WARNING: Attribute 'SAVE' cannot be used more than once
       procedure(procFunc), save, pointer, save :: localProc
+      !ERROR: A PROTECTED entity must be in the specification part of a module
+      real x
+      protected x
     end subroutine testProcDecl
 
 end module m