[LSAN][NFC] Removed FinishThreadLocked from the LSAN interface.

[kstoimenov]

Summary

It is only used in the LSAN specific part.

compiler-rt/lib/lsan/lsan_common.h

bool GetThreadRangesLocked(tid_t os_id, uptr *stack_begin, uptr *stack_end,
                            uptr *tls_begin, uptr *tls_end, uptr *cache_begin,
                            uptr *cache_end, DTLS **dtls);
 void GetAllThreadAllocatorCachesLocked(InternalMmapVector<uptr> *caches);
 void ForEachExtraStackRange(tid_t os_id, RangeIteratorCallback callback,
                             void *arg);
 
 void RunCallbackForEachThreadLocked(__sanitizer::ThreadRegistry::ThreadCallback cb,
                                     void *arg);
-void FinishThreadLocked(u32 tid);
 
 //// --------------------------------------------------------------------------
 //// Allocator prototypes.
 //// --------------------------------------------------------------------------
 
 // Wrappers for allocator's ForceLock()/ForceUnlock().
 void LockAllocator();
 void UnlockAllocator();

compiler-rt/lib/lsan/lsan_fuchsia.cpp

 
 // This is called after creating a new thread (in the creating thread),
 // with the pointer returned by __sanitizer_before_thread_create_hook (above).
 void __sanitizer_thread_create_hook(void *hook, thrd_t thread, int error) {
   u32 tid = static_cast<u32>(reinterpret_cast<uptr>(hook));
   // On success, there is nothing to do here.
   if (error != thrd_success) {
     // Clean up the thread registry for the thread creation that didn't happen.
-    FinishThreadLocked(tid);
+    GetLsanThreadRegistryLocked()->FinishThread(tid);
   }
 }
 
 // This is called in the newly-created thread before it runs anything else,
 // with the pointer returned by __sanitizer_before_thread_create_hook (above).
 void __sanitizer_thread_start_hook(void *hook, thrd_t self) {
   u32 tid = static_cast<u32>(reinterpret_cast<uptr>(hook));
   ThreadStart(tid);
 }
 
 // Each thread runs this just before it exits,
 // with the pointer returned by BeforeThreadCreateHook (above).
 // All per-thread destructors have already been called.
 void __sanitizer_thread_exit_hook(void *hook, thrd_t self) { ThreadFinish(); }
 
 #endif  // SANITIZER_FUCHSIA

compiler-rt/lib/lsan/lsan_thread.cpp

ThreadRegistry *GetLsanThreadRegistryLocked() {
   return thread_registry;
 }
 
 void RunCallbackForEachThreadLocked(
     __sanitizer::ThreadRegistry::ThreadCallback cb, void *arg) {
   GetLsanThreadRegistryLocked()->RunCallbackForEachThreadLocked(cb, arg);
 }
 
-void FinishThreadLocked(u32 tid) {
-  GetLsanThreadRegistryLocked()->FinishThread(tid);
-}
-
 }  // namespace __lsan