This is an archive of the discontinued LLVM Phabricator instance.

Differential D139959

[lld-macho][test] Add test case for section ordering
ClosedPublic

Authored by keith on Dec 13 2022, 11:01 AM.

Details

Reviewers
int3
Group Reviewers
Restricted Project
Commits
rG2e5a0b3d835b: [lld-macho][test] Add test case for section ordering
Summary

This covers the special section ordering handling. This chooses to fake the sections vs creating them organically which is probably a bit easier to maintain.

Diff Detail

Event Timeline

keith created this revision.Dec 13 2022, 11:01 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 13 2022, 11:01 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
keith requested review of this revision.Dec 13 2022, 11:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 11:01 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
int3 accepted this revision.Dec 13 2022, 11:58 AM
int3 added a subscriber: int3.

This chooses to fake the sections vs creating them organically which is probably a bit easier to maintain.

Neat idea :D

lld/test/MachO/section-order.s
8

12 and 21 were so named to reflect the order of the input object files, so 22 doesn't exactly make sense here. Maybe name this synth-section-order instead?

This revision is now accepted and ready to land.Dec 13 2022, 11:58 AM
Harbormaster completed remote builds in B202908: Diff 482562.Dec 13 2022, 12:12 PM
keith updated this revision to Diff 482618.Dec 13 2022, 1:26 PM
keith marked an inline comment as done.

Improve test naming

Harbormaster completed remote builds in B202943: Diff 482618.Dec 13 2022, 1:53 PM
Closed by commit rG2e5a0b3d835b: [lld-macho][test] Add test case for section ordering (authored by keith). · Explain WhyDec 13 2022, 1:56 PM
This revision was automatically updated to reflect the committed changes.
keith added a commit: rG2e5a0b3d835b: [lld-macho][test] Add test case for section ordering.

Revision Contents

PathSize
lld/
test/
MachO/
21 lines

Diff 482623

lld/test/MachO/section-order.s

# REQUIRES: x86 # REQUIRES: x86
## Check that section ordering follows from input file ordering. ## Check that section ordering follows from input file ordering.
# RUN: rm -rf %t; split-file %s %t # RUN: rm -rf %t; split-file %s %t
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/1.s -o %t/1.o # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/1.s -o %t/1.o
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/2.s -o %t/2.o # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/2.s -o %t/2.o
# RUN: %lld -dylib %t/1.o %t/2.o -o %t/12 # RUN: %lld -dylib %t/1.o %t/2.o -o %t/12
# RUN: %lld -dylib %t/2.o %t/1.o -o %t/21 # RUN: %lld -dylib %t/2.o %t/1.o -o %t/21
# RUN: %lld -dylib %t/2.o %t/1.o -o %t/synth-section-order \
int3Unsubmitted
Done
ReplyInline Actions

12 and 21 were so named to reflect the order of the input object files, so 22 doesn't exactly make sense here. Maybe name this synth-section-order instead?

int3: `12` and `21` were so named to reflect the order of the input object files, so `22` doesn't…
# RUN: -add_empty_section __TEXT __objc_stubs \
# RUN: -add_empty_section __TEXT __init_offsets \
# RUN: -add_empty_section __TEXT __stubs \
# RUN: -add_empty_section __TEXT __stub_helper \
# RUN: -add_empty_section __TEXT __unwind_info \
# RUN: -add_empty_section __TEXT __eh_frame \
# RUN: -add_empty_section __DATA __objc_selrefs
# RUN: llvm-objdump --macho --section-headers %t/12 | FileCheck %s --check-prefix=CHECK-12 # RUN: llvm-objdump --macho --section-headers %t/12 | FileCheck %s --check-prefix=CHECK-12
# RUN: llvm-objdump --macho --section-headers %t/21 | FileCheck %s --check-prefix=CHECK-21 # RUN: llvm-objdump --macho --section-headers %t/21 | FileCheck %s --check-prefix=CHECK-21
# RUN: llvm-objdump --macho --section-headers %t/synth-section-order | FileCheck %s --check-prefix=CHECK-SYNTHETIC-ORDER
# CHECK-12: __text # CHECK-12: __text
# CHECK-12-NEXT: foo # CHECK-12-NEXT: foo
# CHECK-12-NEXT: bar # CHECK-12-NEXT: bar
# CHECK-12-NEXT: __cstring # CHECK-12-NEXT: __cstring
# CHECK-21: __text # CHECK-21: __text
# CHECK-21-NEXT: __cstring # CHECK-21-NEXT: __cstring
# CHECK-21-NEXT: bar # CHECK-21-NEXT: bar
# CHECK-21-NEXT: foo # CHECK-21-NEXT: foo
# CHECK-SYNTHETIC-ORDER: __text
# CHECK-SYNTHETIC-ORDER-NEXT: __stubs
# CHECK-SYNTHETIC-ORDER-NEXT: __stub_helper
# CHECK-SYNTHETIC-ORDER-NEXT: __objc_stubs
# CHECK-SYNTHETIC-ORDER-NEXT: __init_offsets
# CHECK-SYNTHETIC-ORDER-NEXT: __cstring
# CHECK-SYNTHETIC-ORDER-NEXT: bar
# CHECK-SYNTHETIC-ORDER-NEXT: foo
# CHECK-SYNTHETIC-ORDER-NEXT: __unwind_info
# CHECK-SYNTHETIC-ORDER-NEXT: __eh_frame
# CHECK-SYNTHETIC-ORDER-NEXT: __objc_selrefs
#--- 1.s #--- 1.s
.section __TEXT,foo .section __TEXT,foo
.space 1 .space 1
.section __TEXT,bar .section __TEXT,bar
.space 1 .space 1
.cstring .cstring
.asciz "" .asciz ""
#--- 2.s #--- 2.s
.cstring .cstring
.asciz "" .asciz ""
.section __TEXT,bar .section __TEXT,bar
.space 1 .space 1
.section __TEXT,foo .section __TEXT,foo
.space 1 .space 1