This is an archive of the discontinued LLVM Phabricator instance.

Differential D139912

[BOLT] Create MailNotifier for NFC check mismatches
ClosedPublic

Authored by Amir on Dec 12 2022, 9:55 PM.

Details

Reviewers
gkistanova
Group Reviewers
Restricted Project
Commits
rZORG549b610e58b3: [BOLT] Create MailNotifier for NFC check mismatches
Summary

Notify about NFC check mismatches (warnings on bolt-nfc builder)

Diff Detail

Event Timeline

Amir created this revision.Dec 12 2022, 9:55 PM
Herald added a reviewer: gkistanova. · View Herald TranscriptDec 12 2022, 9:55 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: treapster. · View Herald Transcript
Amir requested review of this revision.Dec 12 2022, 9:55 PM
Harbormaster completed remote builds in B202755: Diff 482357.Dec 12 2022, 9:55 PM
Amir updated this revision to Diff 482545.Dec 13 2022, 10:17 AM

Update email

Harbormaster completed remote builds in B202895: Diff 482545.Dec 13 2022, 10:17 AM
gkistanova accepted this revision.Dec 14 2022, 1:19 PM

LGTM.

This revision is now accepted and ready to land.Dec 14 2022, 1:19 PM
Amir added a comment.Dec 14 2022, 2:55 PM

Thanks!

Closed by commit rZORG549b610e58b3: [BOLT] Create MailNotifier for NFC check mismatches (authored by Amir). · Explain WhyDec 14 2022, 2:55 PM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rZORG549b610e58b3: [BOLT] Create MailNotifier for NFC check mismatches.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
8 lines

Diff 482357

buildbot/osuosl/master/config/status.py

Show First 20 Lines • Show All 315 Lines • ▼ Show 20 Lines reporters.MailNotifier(
"llvm-clang-x86_64-sie-win"]), "llvm-clang-x86_64-sie-win"]),
reporters.MailNotifier( reporters.MailNotifier(
fromaddr = "llvm.buildmaster@lab.llvm.org", fromaddr = "llvm.buildmaster@lab.llvm.org",
sendToInterestedUsers = False, sendToInterestedUsers = False,
extraRecipients = ["kkleine@redhat.com"], extraRecipients = ["kkleine@redhat.com"],
subject = "Build %(builder)s Failure", subject = "Build %(builder)s Failure",
mode = "failing", mode = "failing",
builders = ["standalone-build-x86_64"]), builders = ["standalone-build-x86_64"]),
reporters.MailNotifier(
fromaddr = "llvm.buildmaster@lab.llvm.org",
sendToInterestedUsers = False,
extraRecipients = ["aaupov@fb.com"],
subject = "BOLT NFC checks mismatch",
mode = "warnings",
builders = ["bolt-x86_64-ubuntu-nfc"]),
] ]
from twisted.python import log from twisted.python import log
# Returns a list of Status Targets. The results of each build will be # Returns a list of Status Targets. The results of each build will be
# pushed to these targets. buildbot.plugins reporters has a variety # pushed to these targets. buildbot.plugins reporters has a variety
# to choose from, including email senders, and IRC bots. # to choose from, including email senders, and IRC bots.
def getReporters(): def getReporters():
if config.options.getboolean('Master Options', 'is_production'): if config.options.getboolean('Master Options', 'is_production'):
log.msg(">>> getReporters: Production mode. All reporters are registered.") log.msg(">>> getReporters: Production mode. All reporters are registered.")
return all return all
else: else:
# Staging buildbot does not report issues. # Staging buildbot does not report issues.
log.msg(">>> getReporters: Staging buildbot does not report issues.") log.msg(">>> getReporters: Staging buildbot does not report issues.")
return [] return []