This is an archive of the discontinued LLVM Phabricator instance.

[GWP-ASan] Fix sanitizer backtrace util using wrong print.
ClosedPublic

Authored by hctim on Dec 9 2022, 4:27 PM.

Details

Summary

The sanitizer backtrace is used in tests, and calling StackTrace.Print()
means that it uses the sanitizer's Printf(), rather than GWP-ASan's
Printf(). In the current code, GWP-ASan's Printf() *is* the sanitizer
print, but this isn't guaranteed to be the case, and will change in an
upcoming patch.

Diff Detail

Event Timeline

hctim created this revision.Dec 9 2022, 4:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 4:27 PM
Herald added a subscriber: Enna1. · View Herald Transcript
hctim requested review of this revision.Dec 9 2022, 4:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 4:27 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Dec 9 2022, 4:31 PM

LGTM

This revision is now accepted and ready to land.Dec 9 2022, 4:31 PM
This revision was automatically updated to reflect the committed changes.