This is an archive of the discontinued LLVM Phabricator instance.

Differential D139734

[LLDB] Remove redundant XFAIL
ClosedPublic

Authored by probinson on Dec 9 2022, 11:40 AM.

Details

Reviewers
labath
Commits
rG5e6467bb3fd2: [lldb] Remove redundant XFAIL
Summary

Part of the project to eliminate special handling for triples in lit
expressions.

Diff Detail

Event Timeline

probinson created this revision.Dec 9 2022, 11:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 11:40 AM
Herald added a subscriber: JDevlieghere. · View Herald Transcript
probinson requested review of this revision.Dec 9 2022, 11:40 AM
Harbormaster completed remote builds in B202278: Diff 481710.Dec 9 2022, 11:44 AM
probinson added a comment.Dec 9 2022, 11:44 AM

The combination of conditions actually looks pretty strange; XFAIL for targeting Arm Linux, yet Unsupported on linux in general.
Naively I'd have thought a test of lldb on the host should nave REQUIRES: native in which case that first XFAIL clause would just go away.

Because this is Unsupported on both Windows and Linux, I can't try it myself. Let me know how you want to handle this.

labath added a comment.Dec 12 2022, 2:24 AM

You can just delete the XFAIL line. I probably should have done that when I added UNSUPPORTED: system-linux in 1004d6e7e2eb24edc01d7e330c538ce5cb590001.

probinson updated this revision to Diff 482093.Dec 12 2022, 5:59 AM

Remove XFAIL

Harbormaster completed remote builds in B202560: Diff 482093.Dec 12 2022, 6:02 AM
probinson retitled this revision from [LLDB] Convert test to use 'target=...' instead of triple check to [LLDB] Remove redundant XFAIL.Dec 12 2022, 6:18 AM
labath accepted this revision.Dec 12 2022, 6:47 AM
This revision is now accepted and ready to land.Dec 12 2022, 6:47 AM
Closed by commit rG5e6467bb3fd2: [lldb] Remove redundant XFAIL (authored by probinson). · Explain WhyDec 12 2022, 8:05 AM
This revision was automatically updated to reflect the committed changes.
probinson added a commit: rG5e6467bb3fd2: [lldb] Remove redundant XFAIL.
Herald added a subscriber: lldb-commits. · View Herald TranscriptDec 12 2022, 8:05 AM

Revision Contents

PathSize
lldb/
test/
Shell/
Recognizer/
1 line

Diff 482134

lldb/test/Shell/Recognizer/assert.test

# XFAIL: target-arm && linux-gnu
# XFAIL: system-freebsd # XFAIL: system-freebsd
# XFAIL: system-netbsd # XFAIL: system-netbsd
# #
# llvm.org/pr56144 # llvm.org/pr56144
# UNSUPPORTED: system-linux # UNSUPPORTED: system-linux
# #
# UNSUPPORTED: system-windows # UNSUPPORTED: system-windows
# RUN: %clang_host -g -O0 %S/Inputs/assert.c -o %t.out # RUN: %clang_host -g -O0 %S/Inputs/assert.c -o %t.out
Show All 11 Lines