This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho][nfc] Fix up missing FileCheck on objc.s
ClosedPublic

Authored by thevinster on Dec 5 2022, 11:55 PM.

Download Raw Diff

Details

Reviewers

thakis
int3

Group Reviewers

Restricted Project

Commits

rGea32faea6dc4: [lld-macho][nfc] Fix up missing FileCheck on objc.s

Summary

I'll be making changes to the ObjC implementation (bug fix) in a later
change, and I noticed that this test isn't being tested at all. Fix that up
here separately so further changes are easier to differentiate.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

thevinster created this revision.Dec 5 2022, 11:55 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 5 2022, 11:55 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

thevinster edited the summary of this revision. (Show Details)Dec 5 2022, 11:57 PM

thevinster edited the summary of this revision. (Show Details)

Filecheck->FileCheck

thevinster published this revision for review.Dec 6 2022, 12:01 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 12:01 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

thevinster edited the summary of this revision. (Show Details)Dec 6 2022, 12:03 AM

Harbormaster completed remote builds in B201297: Diff 480350.Dec 6 2022, 3:21 AM

This revision is now accepted and ready to land.Dec 6 2022, 6:04 AM

nice catch :)

Closed by commit rGea32faea6dc4: [lld-macho][nfc] Fix up missing FileCheck on objc.s (authored by thevinster). · Explain WhyDec 6 2022, 6:42 PM

This revision was automatically updated to reflect the committed changes.

thevinster added a commit: rGea32faea6dc4: [lld-macho][nfc] Fix up missing FileCheck on objc.s.

Revision Contents

Path

Size

lld/

test/

MachO/

objc.s

2 lines

Diff 480734

lld/test/MachO/objc.s

	Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
	## a duplicate symbol error.			## a duplicate symbol error.
	# RUN: not %lld -dylib %t/refs-dup.o %t/refs-objc.o -o %t/refs-dup -L%t \			# RUN: not %lld -dylib %t/refs-dup.o %t/refs-objc.o -o %t/refs-dup -L%t \
	# RUN: -lHasSomeObjC 2>&1 \| FileCheck %s --check-prefix=DUP-ERROR			# RUN: -lHasSomeObjC 2>&1 \| FileCheck %s --check-prefix=DUP-ERROR
	# DUP-ERROR: error: duplicate symbol: _has_dup			# DUP-ERROR: error: duplicate symbol: _has_dup

	## TODO: Load has-objc-symbol.o prior to symbol resolution to match the archive behavior.			## TODO: Load has-objc-symbol.o prior to symbol resolution to match the archive behavior.
	# RUN: not %lld -dylib %t/refs-dup.o %t/refs-objc.o -o %t/refs-dup --start-lib %t/no-objc.o \			# RUN: not %lld -dylib %t/refs-dup.o %t/refs-objc.o -o %t/refs-dup --start-lib %t/no-objc.o \
	# RUN: %t/has-objc-symbol.o %t/has-objc-category.o %t/has-swift.o %t/wrong-arch.o --end-lib \			# RUN: %t/has-objc-symbol.o %t/has-objc-category.o %t/has-swift.o %t/wrong-arch.o --end-lib \
	# RUN: -ObjC --check-prefix=DUP-FROM-OBJC			# RUN: -ObjC 2>&1 \| FileCheck %s --check-prefix=DUP-ERROR

	#--- has-objc-symbol.s			#--- has-objc-symbol.s
	.globl _OBJC_CLASS_$_MyObject, _has_dup			.globl _OBJC_CLASS_$_MyObject, _has_dup
	_OBJC_CLASS_$_MyObject:			_OBJC_CLASS_$_MyObject:

	.section __DATA,has_objc_symbol			.section __DATA,has_objc_symbol
	_has_dup:			_has_dup:

	▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines