[AVR] Register AVRDAGToDAGISel pass with the pass manager

[eugmes]

Summary

This makes it possible to see the output from the pass when using --print-after-all and other command line options.

[eugmes]

A static char ID needs to be added to AVRDAGToDAGISel, and probably to AMDGPUDAGToDAGISel.

llvm/lib/Target/AVR/AVRISelDAGToDAG.cpp

588

I think this requires a new instance of ID for the class to be registered. And somebody else is also missing it and uses one from SelectionDAGISel (AMDGPUDAGToDAGISel is one of such classes). That's why there is a double registration error.

[eugmes]

It looks like all ISel pass classes have shared ID thanks to SelectionDAGISel and fixing this is more complicated.

llvm/lib/Target/AVR/AVR.h

 
 Pass *createAVRShiftExpandPass();
 FunctionPass *createAVRISelDag(AVRTargetMachine &TM,
                                CodeGenOpt::Level OptLevel);
 FunctionPass *createAVRExpandPseudoPass();
 FunctionPass *createAVRFrameAnalyzerPass();
 FunctionPass *createAVRBranchSelectionPass();
 
+void initializeAVRDAGToDAGISelPass(PassRegistry &);
 void initializeAVRShiftExpandPass(PassRegistry &);
 void initializeAVRExpandPseudoPass(PassRegistry &);
 
 /// Contains the AVR backend.
 namespace AVR {
 
 /// An integer that identifies all of the supported AVR address spaces.
 enum AddressSpace {

llvm/lib/Target/AVR/AVRISelDAGToDAG.cpp

 
 #define DEBUG_TYPE "avr-isel"
 
 namespace llvm {
 
 /// Lowers LLVM IR (in DAG form) to AVR MC instructions (in DAG form).
 class AVRDAGToDAGISel : public SelectionDAGISel {
 public:
-  AVRDAGToDAGISel(AVRTargetMachine &TM, CodeGenOpt::Level OptLevel)
-      : SelectionDAGISel(TM, OptLevel), Subtarget(nullptr) {}
+  explicit AVRDAGToDAGISel(AVRTargetMachine *TM = nullptr,
+                           CodeGenOpt::Level OptLevel = CodeGenOpt::Default)
+      : SelectionDAGISel(*TM, OptLevel), Subtarget(nullptr) {}
 
   StringRef getPassName() const override {
     return "AVR DAG->DAG Instruction Selection";
   }
 
   bool runOnMachineFunction(MachineFunction &MF) override;
 
   bool SelectAddr(SDNode *Op, SDValue N, SDValue &Base, SDValue &Disp);
case AVRISD::CALL:
     return select<AVRISD::CALL>(N);
   default:
     return false;
   }
 }
 
 FunctionPass *createAVRISelDag(AVRTargetMachine &TM,
                                CodeGenOpt::Level OptLevel) {
-  return new AVRDAGToDAGISel(TM, OptLevel);
+  return new AVRDAGToDAGISel(&TM, OptLevel);
 }
 
 } // end of namespace llvm
+
+using namespace llvm;
+
+INITIALIZE_PASS(AVRDAGToDAGISel, "avr-isel",
+                "AVR DAG->DAG Instruction Selection", false, false)

llvm/lib/Target/AVR/AVRTargetMachine.cpp

void AVRPassConfig::addIRPasses() {
   TargetPassConfig::addIRPasses();
 }
 
 extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeAVRTarget() {
   // Register the target.
   RegisterTargetMachine<AVRTargetMachine> X(getTheAVRTarget());
 
   auto &PR = *PassRegistry::getPassRegistry();
+  initializeAVRDAGToDAGISelPass(PR);
   initializeAVRExpandPseudoPass(PR);
   initializeAVRShiftExpandPass(PR);
 }
 
 const AVRSubtarget *AVRTargetMachine::getSubtargetImpl() const {
   return &SubTarget;
 }