This is an archive of the discontinued LLVM Phabricator instance.

Differential D139144

[flang] Emit portability warning for assigned FORMAT use
ClosedPublic

Authored by klausler on Dec 1 2022, 2:08 PM.

Details

Reviewers
vdonaldson
Commits
rG9c1ad89d0e77: [flang] Emit portability warning for assigned FORMAT use
Summary

Emit a portability warning about usage of a deprecated feature
when an I/O data transfer statement uses a scalar integer
variable as an assigned format.

Diff Detail

Event Timeline

klausler created this revision.Dec 1 2022, 2:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2022, 2:08 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Dec 1 2022, 2:08 PM
vdonaldson accepted this revision.Dec 1 2022, 3:07 PM
This revision is now accepted and ready to land.Dec 1 2022, 3:07 PM
Harbormaster completed remote builds in B200625: Diff 479426.Dec 1 2022, 5:46 PM
Closed by commit rG9c1ad89d0e77: [flang] Emit portability warning for assigned FORMAT use (authored by klausler). · Explain WhyDec 3 2022, 5:38 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG9c1ad89d0e77: [flang] Emit portability warning for assigned FORMAT use.

Revision Contents

PathSize
flang/
lib/
Semantics/
3 lines

Diff 479883

flang/lib/Semantics/check-io.cpp

Show First 20 Lines • Show All 225 Lines • ▼ Show 20 Lines common::visit(
if (type && type->category() == TypeCategory::Integer && if (type && type->category() == TypeCategory::Integer &&
type->kind() == type->kind() ==
context_.defaultKinds().GetDefaultKind(type->category()) && context_.defaultKinds().GetDefaultKind(type->category()) &&
expr->Rank() == 0) { expr->Rank() == 0) {
flags_.set(Flag::AssignFmt); flags_.set(Flag::AssignFmt);
if (!IsVariable(*expr)) { if (!IsVariable(*expr)) {
context_.Say(format.source, context_.Say(format.source,
"Assigned format label must be a scalar variable"_err_en_US); "Assigned format label must be a scalar variable"_err_en_US);
} else if (context_.ShouldWarn(common::LanguageFeature::Assign)) {
context_.Say(format.source,
"Assigned format labels are deprecated"_port_en_US);
} }
return; return;
} }
if (type && type->category() != TypeCategory::Character && if (type && type->category() != TypeCategory::Character &&
(type->category() != TypeCategory::Integer || (type->category() != TypeCategory::Integer ||
expr->Rank() > 0) && expr->Rank() > 0) &&
context_.IsEnabled( context_.IsEnabled(
common::LanguageFeature::NonCharacterFormat)) { common::LanguageFeature::NonCharacterFormat)) {
▲ Show 20 Lines • Show All 931 Lines • Show Last 20 Lines