This is an archive of the discontinued LLVM Phabricator instance.

[clang] Add test for CWG360
ClosedPublic

Authored by Endill on Dec 1 2022, 2:56 AM.

Details

Reviewers
aaron.ballman
Group Reviewers
Restricted Project
Commits
rG3f950ad58919: [clang] Add test for CWG360
Summary

P1787: "CWG360 is resolved by applying access control to using-declarations."
class.access.general#4: "When a using-declarator is named, access control is applied to it, not to the declarations that replace it."

Diff Detail

Event Timeline

Endill created this revision.Dec 1 2022, 2:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2022, 2:56 AM
Endill requested review of this revision.Dec 1 2022, 2:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2022, 2:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Endill updated this revision to Diff 479225.Dec 1 2022, 2:59 AM

run make_cxx_dr_status

aaron.ballman accepted this revision.Dec 1 2022, 5:53 AM
aaron.ballman added a subscriber: aaron.ballman.

LGTM!

This revision is now accepted and ready to land.Dec 1 2022, 5:53 AM
This revision was landed with ongoing or failed builds.Dec 1 2022, 6:24 AM
This revision was automatically updated to reflect the committed changes.
erichkeane added inline comments.
clang/test/CXX/drs/dr3xx.cpp
908

This bookmark isn't necessary, so no reason to have it. But thank you for using these!

Endill added inline comments.Dec 1 2022, 6:45 AM
clang/test/CXX/drs/dr3xx.cpp
908

Nice catch, thank you!
Seems like I should've waited a bit more before committing.

aaron.ballman added inline comments.Dec 1 2022, 6:46 AM
clang/test/CXX/drs/dr3xx.cpp
908

Good catch Erich!

Feel free to fix the comment up with an NFC commit (you don't need anyone to review it because there's no functional change).

erichkeane added inline comments.Dec 1 2022, 7:25 AM
clang/test/CXX/drs/dr3xx.cpp
908

Don't worry about it, this is a trivial issue I just saw while scrolling/admiring the bookmarks :D a follow-up review-after-commit patch would be fine here.