This is an archive of the discontinued LLVM Phabricator instance.

[Threading] Ensure Tests Reflect Disabled Threads
ClosedPublic

Authored by lenary on Nov 30 2022, 7:41 AM.

Details

Summary

D137836 changed what llvm::get_physical_cores returns when threads are
disabled, to bring it inline with the other parts of Threading. It now
returns the value for "unknown" when threading is disabled.

This commit updates the tests (which are failing on some platforms), to
also reflect this change.

Diff Detail

Event Timeline

lenary created this revision.Nov 30 2022, 7:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 7:41 AM
lenary requested review of this revision.Nov 30 2022, 7:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 7:41 AM
DavidSpickett accepted this revision.Nov 30 2022, 8:00 AM

LGTM, thanks.

This revision is now accepted and ready to land.Nov 30 2022, 8:00 AM
This revision was landed with ongoing or failed builds.Nov 30 2022, 9:03 AM
This revision was automatically updated to reflect the committed changes.