This is an archive of the discontinued LLVM Phabricator instance.

Differential D138968

[runtimes] Add check-profile dependencies to runtimes
ClosedPublic

Authored by smeenai on Nov 29 2022, 5:47 PM.

Details

Reviewers
ellis
phosek
Commits
rGa57d91ef6bff: [runtimes] Add check-profile dependencies to runtimes
Summary

check-profile needs llvm-cov and llvm-profdata.

Diff Detail

Event Timeline

smeenai created this revision.Nov 29 2022, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 5:47 PM
smeenai requested review of this revision.Nov 29 2022, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 5:47 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
phosek accepted this revision.Nov 29 2022, 7:08 PM

LGTM

This revision is now accepted and ready to land.Nov 29 2022, 7:08 PM
Harbormaster completed remote builds in B200150: Diff 478770.Nov 29 2022, 7:54 PM
Closed by commit rGa57d91ef6bff: [runtimes] Add check-profile dependencies to runtimes (authored by smeenai). · Explain WhyNov 30 2022, 11:15 AM
This revision was automatically updated to reflect the committed changes.
smeenai added a commit: rGa57d91ef6bff: [runtimes] Add check-profile dependencies to runtimes.

Revision Contents

PathSize
llvm/
runtimes/
2 lines

Diff 479031

llvm/runtimes/CMakeLists.txt

Show First 20 Lines • Show All 478 Lines • ▼ Show 20 Linesif(runtimes)
endif() endif()
if(LLVM_INCLUDE_TESTS) if(LLVM_INCLUDE_TESTS)
set_property(GLOBAL APPEND PROPERTY LLVM_ALL_ADDITIONAL_TEST_DEPENDS runtimes-test-depends) set_property(GLOBAL APPEND PROPERTY LLVM_ALL_ADDITIONAL_TEST_DEPENDS runtimes-test-depends)
set(RUNTIMES_TEST_DEPENDS set(RUNTIMES_TEST_DEPENDS
FileCheck FileCheck
count count
llvm-cov
llvm-nm llvm-nm
llvm-objdump llvm-objdump
llvm-profdata
llvm-xray llvm-xray
not not
obj2yaml obj2yaml
sancov sancov
sanstats sanstats
llvm_gtest_main llvm_gtest_main
llvm_gtest llvm_gtest
) )
foreach(target ${test_targets} ${SUB_CHECK_TARGETS}) foreach(target ${test_targets} ${SUB_CHECK_TARGETS})
add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS}) add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS})
endforeach() endforeach()
set_property(GLOBAL APPEND PROPERTY LLVM_ALL_ADDITIONAL_TEST_TARGETS runtimes ${RUNTIMES_TEST_DEPENDS}) set_property(GLOBAL APPEND PROPERTY LLVM_ALL_ADDITIONAL_TEST_TARGETS runtimes ${RUNTIMES_TEST_DEPENDS})
endif() endif()
endif() endif()