This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Support sub-components in LLVM_RUNTIME_DISTRIBUTION_COMPONENTS
ClosedPublic

Authored by smeenai on Nov 29 2022, 5:47 PM.

Details

Summary

Right now, sub-components are only accounted for when the runtime has
been configured and the main LLVM configure is rerun after that. We can
make use of LLVM_RUNTIME_DISTRIBUTION_COMPONENTS to make sub-component
targets available from the start, but that currently clashes with the
sub-component target generation once they are picked up. Make sure we
don't create duplicate targets; an analogous check already exists in
runtime_default_target.

Diff Detail

Event Timeline

smeenai created this revision.Nov 29 2022, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 5:47 PM
smeenai requested review of this revision.Nov 29 2022, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 5:47 PM
phosek accepted this revision.Nov 29 2022, 10:35 PM

LGTM

This revision is now accepted and ready to land.Nov 29 2022, 10:35 PM