This is an archive of the discontinued LLVM Phabricator instance.

[clang][Fuchsia] Allow for setting the default build type
Needs ReviewPublic

Authored by leonardchan on Nov 28 2022, 12:35 PM.

Details

Reviewers
phosek
Summary

Prior to this, CMAKE_BUILD_TYPE would unconditionally be Release. This allows me to add -DCMAKE_BUILD_TYPE=Debug to override this rather than manually changing the cache file.

Diff Detail

Event Timeline

leonardchan created this revision.Nov 28 2022, 12:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 12:35 PM
Herald added a subscriber: abrachet. · View Herald Transcript
leonardchan requested review of this revision.Nov 28 2022, 12:35 PM

This shouldn't be needed, you can do:

cmake ... -DCMAKE_BUILD_TYPE=Debug -C path/to/Fuchsia-stage2.cmake

This will override the value inside the cache file.