This is an archive of the discontinued LLVM Phabricator instance.

Differential D138800

PredicateInfo: Convert test to opaque pointers
ClosedPublic

Authored by arsenm on Nov 28 2022, 5:49 AM.

Details

Reviewers
fhahn
nikic
Summary

Drops the "has predicate info" for the first block.

Diff Detail

Unit TestsFailed

TimeTest
190 msx64 debian > LLVM.Examples/OrcV2Examples::lljit-with-thinlto-summaries.test
60,080 msx64 debian > MLIR.Examples/standalone::test.toy
60,040 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

arsenm created this revision.Nov 28 2022, 5:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 5:49 AM
arsenm requested review of this revision.Nov 28 2022, 5:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 5:49 AM
Herald added a subscriber: wdng. · View Herald Transcript
Harbormaster completed remote builds in B199735: Diff 478206.Nov 28 2022, 6:36 AM
nikic added inline comments.Dec 5 2022, 3:03 AM
llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll
28

We need a use of %arg here. With the bitcast gone, adding %u2 = call ptr @fun(ptr %arg) should do.

arsenm updated this revision to Diff 480097.Dec 5 2022, 7:09 AM
arsenm marked an inline comment as done.

Add new user

nikic accepted this revision.Dec 5 2022, 7:11 AM

LG

This revision is now accepted and ready to land.Dec 5 2022, 7:11 AM
arsenm closed this revision.Dec 5 2022, 8:42 AM

c6a5057453cb9ed7c4814e4c2267d1eabacd1706

Harbormaster completed remote builds in B201111: Diff 480097.Dec 5 2022, 11:05 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
Util/
PredicateInfo/
20 lines

Diff 478206

llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll

; RUN: opt < %s -passes=print-predicateinfo 2>&1 | FileCheck %s ; RUN: opt -disable-output -passes=print-predicateinfo < %s 2>&1 | FileCheck %s
%1 = type opaque %1 = type opaque
%0 = type opaque %0 = type opaque
; Check we can use ssa.copy with unnamed types. ; Check we can use ssa.copy with unnamed types.
; CHECK-LABEL: bb: ; CHECK-LABEL: bb:
; CHECK: Has predicate info
; CHECK: branch predicate info { TrueEdge: 1 Comparison: %cmp1 = icmp ne %0* %arg, null Edge: [label %bb,label %bb1], RenamedOp: %arg }
; CHECK-NEXT: %arg.0 = call %0* @llvm.ssa.copy.p0s_s.{{.+}}(%0* %arg)
; CHECK-LABEL: bb1: ; CHECK-LABEL: bb1:
; CHECK: Has predicate info ; CHECK: Has predicate info
; CHECK-NEXT: branch predicate info { TrueEdge: 0 Comparison: %cmp2 = icmp ne %1* null, %tmp Edge: [label %bb1,label %bb3], RenamedOp: %tmp } ; CHECK-NEXT: branch predicate info { TrueEdge: 0 Comparison: %cmp2 = icmp ne ptr null, %tmp Edge: [label %bb1,label %bb3], RenamedOp: %tmp }
; CHECK-NEXT: %tmp.0 = call %1* @llvm.ssa.copy.p0s_s.{{.+}}(%1* %tmp) ; CHECK-NEXT: %tmp.0 = call ptr @llvm.ssa.copy.p0(ptr %tmp)
define void @f0(%0* %arg, %1* %tmp) { define void @f0(ptr %arg, ptr %tmp) {
bb: bb:
%cmp1 = icmp ne %0* %arg, null %cmp1 = icmp ne ptr %arg, null
br i1 %cmp1, label %bb1, label %bb2 br i1 %cmp1, label %bb1, label %bb2
bb1: ; preds = %bb bb1: ; preds = %bb
%cmp2 = icmp ne %1* null, %tmp %cmp2 = icmp ne ptr null, %tmp
br i1 %cmp2, label %bb2, label %bb3 br i1 %cmp2, label %bb2, label %bb3
bb2: ; preds = %bb bb2: ; preds = %bb
ret void ret void
bb3: ; preds = %bb bb3: ; preds = %bb
%u1 = call i8* @fun(%1* %tmp) %u1 = call ptr @fun(ptr %tmp)
nikicUnsubmitted
Done
ReplyInline Actions

We need a use of %arg here. With the bitcast gone, adding %u2 = call ptr @fun(ptr %arg) should do.

nikic: We need a use of `%arg` here. With the bitcast gone, adding `%u2 = call ptr @fun(ptr %arg)`…
%tmp2 = bitcast %0* %arg to i8*
ret void ret void
} }
declare i8* @fun(%1*) declare ptr @fun(ptr)