This is an archive of the discontinued LLVM Phabricator instance.

[include-cleaner] Make Symbol (and Macro) hashable.
ClosedPublic

Authored by sammccall on Nov 24 2022, 3:31 AM.

Details

Summary

For now, we decided not to add operator< or handle other variants.
(If we do so in future we may want to extract a base class).

Diff Detail

Event Timeline

sammccall created this revision.Nov 24 2022, 3:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2022, 3:31 AM
sammccall requested review of this revision.Nov 24 2022, 3:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2022, 3:31 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kadircet accepted this revision.Nov 24 2022, 4:40 AM

thanks, lgtm!

clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h
146

probably left over?

This revision is now accepted and ready to land.Nov 24 2022, 4:40 AM
sammccall marked an inline comment as done.Nov 24 2022, 6:15 AM
This revision was automatically updated to reflect the committed changes.