This is an archive of the discontinued LLVM Phabricator instance.

HIP: Directly call fabs builtins
ClosedPublic

Authored by arsenm on Nov 20 2022, 8:45 PM.

Details

Summary

All the attribute numbering changes are due to the ocml function being
assumed convergent, and the direct call is not.

This begins a series of patches to avoid using the thinnest
ocml wrappers around llvm intrinsics. These wrapper functions
aren't buying anything and add complexity. As we do not propagate
fast math flags into the library on linking, and cannot generally
safely do so, we're losing information by calling into them. Directly
call the builtins so we get the fast math flags set appropriate for the
translation unit naturally.

Diff Detail

Event Timeline

arsenm created this revision.Nov 20 2022, 8:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2022, 8:45 PM
arsenm requested review of this revision.Nov 20 2022, 8:45 PM
yaxunl accepted this revision.Dec 1 2022, 2:57 PM

LGTM. Thanks

This revision is now accepted and ready to land.Dec 1 2022, 2:57 PM