This is an archive of the discontinued LLVM Phabricator instance.

[clang] Fix wrong ABI on AVRTiny
ClosedPublic

Authored by benshi001 on Nov 16 2022, 5:17 AM.

Details

Summary

A scalar which exceeds 4 bytes should be returned
via a stack slot, on AVRTiny.

Diff Detail

Event Timeline

benshi001 created this revision.Nov 16 2022, 5:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2022, 5:17 AM
Herald added a subscriber: Jim. · View Herald Transcript
benshi001 requested review of this revision.Nov 16 2022, 5:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2022, 5:17 AM
benshi001 added inline comments.Nov 16 2022, 5:19 AM
clang/test/CodeGen/avr/return-value.c
37

This file should be renamed to return.c instead of current struct.c, I will do that in another patch, just let you see clearly what I have changed.

aykevl added inline comments.Nov 16 2022, 5:39 AM
clang/test/CodeGen/avr/return-value.c
37

You can do that in the same patch. Phabricator should detect the renamed file and display it just like it does now.

aykevl accepted this revision.Nov 16 2022, 5:50 AM
This revision is now accepted and ready to land.Nov 16 2022, 5:50 AM
benshi001 updated this revision to Diff 475808.Nov 16 2022, 6:02 AM
benshi001 marked an inline comment as done.Nov 16 2022, 6:07 AM
benshi001 added inline comments.
clang/test/CodeGen/avr/return-value.c
37

thanks.

aykevl accepted this revision.Nov 16 2022, 6:09 AM
benshi001 marked an inline comment as done.Nov 16 2022, 6:29 AM
This revision was automatically updated to reflect the committed changes.