This is an archive of the discontinued LLVM Phabricator instance.

Differential D137942

[CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)
ClosedPublic

Authored by sgraenitz on Nov 14 2022, 6:09 AM.

Details

Reviewers
triplef
Commits
rG63d65d3764ea: Reland "[CGObjC] Add run line for release mode in test arc-exceptions-seh.mm…
rG01023bfcd33f: [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)
Summary

In release mode the updated arc-exceptions-seh.mm test fails and needs -enable-objc-arc-opts=false to skip ObjC ARC optimizations.

Diff Detail

Event Timeline

sgraenitz created this revision.Nov 14 2022, 6:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 6:09 AM
sgraenitz requested review of this revision.Nov 14 2022, 6:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 6:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B197518: Diff 475127.Nov 14 2022, 6:10 AM
sgraenitz added a parent revision: D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early.Nov 14 2022, 6:10 AM
sgraenitz removed a parent revision: D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early.
sgraenitz added a child revision: D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early.
sgraenitz added a parent revision: D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens.Nov 14 2022, 6:35 AM
sgraenitz added a reviewer: triplef.Nov 14 2022, 6:58 AM
triplef accepted this revision.Nov 16 2022, 2:49 AM
This revision is now accepted and ready to land.Nov 16 2022, 2:49 AM
This revision was landed with ongoing or failed builds.Nov 22 2022, 4:43 AM
Closed by commit rG01023bfcd33f: [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC) (authored by sgraenitz). · Explain Why
This revision was automatically updated to reflect the committed changes.
sgraenitz added a commit: rG01023bfcd33f: [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC).
sgraenitz added a reverting change: rGa37807ac8a3e: Revert "[CGObjC] Add run line for release mode in test arc-exceptions-seh.mm….Nov 22 2022, 11:55 AM
sgraenitz added a comment.Nov 22 2022, 12:02 PM

The Buildbot has detected a failed build on builder sanitizer-aarch64-linux-bootstrap-ubsan while building clang,compiler-rt. I will investigate tomorrow and reverted the change in the meantime. Full error output:

******************** TEST 'Clang :: CodeGenObjCXX/arc-exceptions-seh.mm' FAILED ********************
Script:
--
: 'RUN: at line 1';   /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/clang -cc1 -internal-isystem /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/lib/clang/16/include -nostdsysteminc -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -o - /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/test/CodeGenObjCXX/arc-exceptions-seh.mm | /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/FileCheck /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/test/CodeGenObjCXX/arc-exceptions-seh.mm --check-prefixes=CHECK,CHECK-O0
: 'RUN: at line 2';   /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/clang -cc1 -internal-isystem /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/lib/clang/16/include -nostdsysteminc -O2 -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -mllvm -enable-objc-arc-opts=false -o - /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/test/CodeGenObjCXX/arc-exceptions-seh.mm | /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/FileCheck /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/test/CodeGenObjCXX/arc-exceptions-seh.mm --check-prefixes=CHECK,CHECK-O2
--
Exit Code: 2

Command Output (stderr):
--
llvm-project/llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:577:41: runtime error: load of value 180, which is not a valid value for type 'bool'
    #0 0xaaaae3333a30 in hasCFGChanged llvm-project/llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:577:41
    #1 0xaaaae3333a30 in llvm::ObjCARCOptPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) llvm-project/llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:2494:26
    #2 0xaaaae202100c in llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) llvm-project/llvm/include/llvm/IR/PassManager.h:517:40
    #3 0xaaaae1557168 in llvm::CGSCCToFunctionPassAdaptor::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:541:38
    #4 0xaaaae1552b10 in llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:87:38
    #5 0xaaaae155587c in llvm::DevirtSCCRepeatedPass::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:409:38
    #6 0xaaaae15540b8 in llvm::ModuleToPostOrderCGSCCPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:277:44
    #7 0xaaaae20204a8 in llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) llvm-project/llvm/include/llvm/IR/PassManager.h:517:40
    #8 0xaaaae21794cc in llvm::ModuleInlinerWrapperPass::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) llvm-project/llvm/lib/Transforms/IPO/Inliner.cpp:1170:7
    #9 0xaaaae20204a8 in llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) llvm-project/llvm/include/llvm/IR/PassManager.h:517:40
    #10 0xaaaae33186bc in (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::__1::unique_ptr<llvm::raw_pwrite_stream, std::__1::default_delete<llvm::raw_pwrite_stream>>&, std::__1::unique_ptr<llvm::ToolOutputFile, std::__1::default_delete<llvm::ToolOutputFile>>&) llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1028:9
    #11 0xaaaae3312ed8 in EmitAssembly llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1085:3
    #12 0xaaaae3312ed8 in clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, std::__1::unique_ptr<llvm::raw_pwrite_stream, std::__1::default_delete<llvm::raw_pwrite_stream>>) llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1244:13
    #13 0xaaaae370da78 in clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) llvm-project/clang/lib/CodeGen/CodeGenAction.cpp:381:7
    #14 0xaaaae4ee63f8 in clang::ParseAST(clang::Sema&, bool, bool) llvm-project/clang/lib/Parse/ParseAST.cpp:196:13
    #15 0xaaaae3614e64 in clang::FrontendAction::Execute() llvm-project/clang/lib/Frontend/FrontendAction.cpp:1055:8
    #16 0xaaaae35acff4 in clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) llvm-project/clang/lib/Frontend/CompilerInstance.cpp:1045:33
    #17 0xaaaae3707c84 in clang::ExecuteCompilerInvocation(clang::CompilerInstance*) llvm-project/clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:264:25
    #18 0xaaaadff139d8 in cc1_main(llvm::ArrayRef<char const*>, char const*, void*) llvm-project/clang/tools/driver/cc1_main.cpp:250:15
    #19 0xaaaadff0b904 in ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) llvm-project/clang/tools/driver/driver.cpp:319:12
    #20 0xaaaadff09070 in clang_main(int, char**) llvm-project/clang/tools/driver/driver.cpp:395:12
    #21 0xffff897f73f8  (/lib/aarch64-linux-gnu/libc.so.6+0x273f8) (BuildId: f37f3aa07c797e333fd106472898d361f71798f5)
    #22 0xffff897f74c8 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x274c8) (BuildId: f37f3aa07c797e333fd106472898d361f71798f5)
    #23 0xaaaadfee1e2c in _start (llvm_build_ubsan/bin/clang-16+0xa701e2c)
sgraenitz mentioned this in rGc20a80092c15: [ObjC][ARC] Fix UB in ObjCARCOpt with -enable-objc-arc-opts=false.Nov 23 2022, 2:36 AM
sgraenitz added a commit: rG63d65d3764ea: Reland "[CGObjC] Add run line for release mode in test arc-exceptions-seh.mm….

Revision Contents

Diff 477140

clang/test/CodeGenObjCXX/arc-exceptions-seh.mm

// RUN: %clang_cc1 -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -o - %s | FileCheck %s // RUN: %clang_cc1 -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-O0
// RUN: %clang_cc1 -O2 -triple x86_64-pc-windows-msvc -emit-llvm -fobjc-arc -fexceptions -fobjc-exceptions -fobjc-arc-exceptions -fobjc-runtime=gnustep-2.0 -mllvm -enable-objc-arc-opts=false -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-O2
// WinEH requires funclet tokens on nounwind intrinsics if they can lower to // WinEH requires funclet tokens on nounwind intrinsics if they can lower to
// regular function calls in the course of IR transformations. // regular function calls in the course of IR transformations.
// //
// This is the case for ObjC ARC runtime intrinsics. Test that clang emits the // This is the case for ObjC ARC runtime intrinsics. Test that clang emits the
// funclet tokens for llvm.objc.* calls inside catch- and cleanup-pads and that // funclet tokens for llvm.objc.* calls inside catch- and cleanup-pads and that
// they refer to their pad's SSA value. // they refer to their pad's SSA value.
Show All 25 Lines
// CHECK: do_something // CHECK: do_something
// CHECK: [ "funclet"(token [[CATCHPAD]]) ] // CHECK: [ "funclet"(token [[CATCHPAD]]) ]
// CHECK: unwind label %[[CLEANUP2:.*]] // CHECK: unwind label %[[CLEANUP2:.*]]
// CHECK: invoke // CHECK: invoke
// CHECK: may_throw // CHECK: may_throw
// CHECK: [ "funclet"(token [[CATCHPAD]]) ] // CHECK: [ "funclet"(token [[CATCHPAD]]) ]
// CHECK: unwind label %[[CLEANUP2]] // CHECK: unwind label %[[CLEANUP2]]
// CHECK: call // CHECK: call
// CHECK: @llvm.objc.storeStrong // CHECK-O0: @llvm.objc.storeStrong
// CHECK-O2: @llvm.objc.release
// CHECK: [ "funclet"(token [[CATCHPAD]]) ] // CHECK: [ "funclet"(token [[CATCHPAD]]) ]
// CHECK: catchret from [[CATCHPAD]] to label %catchret.dest // CHECK-O0: catchret from [[CATCHPAD]] to label %catchret.dest
// CHECK-O2: catchret from [[CATCHPAD]] to label %eh.cont
// //
// This block exists and it's empty: // In debug mode, this block exists and it's empty:
// CHECK: catchret.dest: // CHECK-O0: catchret.dest:
// CHECK-NEXT: br label %eh.cont // CHECK-O0-NEXT: br label %eh.cont
// //
// CHECK: [[CLEANUP2]]: // CHECK: [[CLEANUP2]]:
// CHECK-NEXT: [[CLEANUPPAD2:%[0-9]+]] = cleanuppad within [[CATCHPAD]] // CHECK-NEXT: [[CLEANUPPAD2:%[0-9]+]] = cleanuppad within [[CATCHPAD]]
// CHECK: call // CHECK: call
// CHECK: @llvm.objc.storeStrong // CHECK-O0: @llvm.objc.storeStrong
// CHECK-O2: @llvm.objc.release
// CHECK: [ "funclet"(token [[CLEANUPPAD2]]) ] // CHECK: [ "funclet"(token [[CLEANUPPAD2]]) ]
// CHECK: cleanupret from [[CLEANUPPAD2]] // CHECK: cleanupret from [[CLEANUPPAD2]]
// CHECK: unwind label %[[CLEANUP1]] // CHECK: unwind label %[[CLEANUP1]]
// //
// CHECK: [[CLEANUP1]]: // CHECK: [[CLEANUP1]]:
// CHECK-NEXT: [[CLEANUPPAD1:%[0-9]+]] = cleanuppad within none // CHECK-NEXT: [[CLEANUPPAD1:%[0-9]+]] = cleanuppad within none
// CHECK: call // CHECK: call
// CHECK: @llvm.objc.storeStrong // CHECK-O0: @llvm.objc.storeStrong
// CHECK-O2: @llvm.objc.release
// CHECK: [ "funclet"(token [[CLEANUPPAD1]]) ] // CHECK: [ "funclet"(token [[CLEANUPPAD1]]) ]
// CHECK: cleanupret from [[CLEANUPPAD1]] unwind to caller // CHECK: cleanupret from [[CLEANUPPAD1]] unwind to caller