Page MenuHomePhabricator

[BOLT] Enable clang-bolt for host-gcc-built Clang
ClosedPublic

Authored by Amir on Nov 8 2022, 4:38 PM.

Details

Reviewers
gkistanova
Group Reviewers
Restricted Project
Commits
rZORG7e6d7a663c71: [BOLT] Enable clang-bolt for host-gcc-built Clang
Summary

Follow-up to D136410 and D137357.

Diff Detail

Event Timeline

Amir created this revision.Nov 8 2022, 4:38 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: treapster. · View Herald Transcript
Amir requested review of this revision.Nov 8 2022, 4:38 PM

Thanks, Amir.

The patch itself looks good.

The bolt-worker seems overloaded, though. It hosts 6 builders, only one build is allowed at any given moment of time. The current waiting queue for each builder is about 2 hours, even if builds themselves are fast. Adding one more builder to the same worker will make it worse.

Amir added a comment.Nov 15 2022, 3:58 PM

Thanks, Amir.

The patch itself looks good.

The bolt-worker seems overloaded, though. It hosts 6 builders, only one build is allowed at any given moment of time. The current waiting queue for each builder is about 2 hours, even if builds themselves are fast. Adding one more builder to the same worker will make it worse.

bolt-x86_64-ubuntu is going away, but I agree that waiting time is quite high now, largely driven by msvc-wine builder. We'll discuss within the team if we want to keep it.

This revision is now accepted and ready to land.Nov 15 2022, 5:22 PM
Amir updated this revision to Diff 487280.Sun, Jan 8, 9:25 PM

Don't collapse requests, run check-clang

Amir updated this revision to Diff 487281.Sun, Jan 8, 9:25 PM

Remove unrelated changes

gkistanova accepted this revision.Fri, Jan 13, 12:04 PM

Thanks, Amir!

This revision was automatically updated to reflect the committed changes.