This is an archive of the discontinued LLVM Phabricator instance.

Fix test TestVSCode_terminatedEvent.py
AbandonedPublic

Authored by kusmour on Nov 4 2022, 12:07 PM.

Details

Summary

This test is broken due to the flaky encoding of top-level JSON key 'memory'
When testing locally (linux) the test passed. However, it failed the build bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48111/
I will find a way to repro before I can actually fix this issue correctly.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

kusmour created this revision.Nov 4 2022, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 12:07 PM
kusmour requested review of this revision.Nov 4 2022, 12:07 PM
GeorgeHuyubo accepted this revision.Nov 4 2022, 2:05 PM
This revision is now accepted and ready to land.Nov 4 2022, 2:05 PM
clayborg requested changes to this revision.Nov 4 2022, 3:14 PM

There are some other issues going on in the JSON. See:

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48111/testReport/junit/lldb-api/tools_lldb-vscode_terminated-event/TestVSCode_terminatedEvent_py/

We seem the have a lifetime issue with the "memory" string value's lifetime

{"event":"terminated","seq":0,"statistics":{"\u0000\u0000\u0000\u0000\u0000\u0000":"{\"strings\":

So there is a bug here we need to fix. The above first key should be "memory", not "\u0000\u0000\u0000\u0000\u0000\u0000"

This revision now requires changes to proceed.Nov 4 2022, 3:14 PM

The original patch was reverted, so this can be abandoned.

kusmour abandoned this revision.Nov 4 2022, 6:21 PM

Original patch is reverted (https://reviews.llvm.org/D137003)