This is an archive of the discontinued LLVM Phabricator instance.

[libc++] newlib/xlocale.h: remove redundant includes
ClosedPublic

Authored by michaelplatings on Oct 28 2022, 6:33 AM.

Details

Reviewers
ldionne
philnik
Group Reviewers
Restricted Project
Commits
rG77793ee33a7d: [libc++] newlib/xlocale.h: remove redundant includes
Summary

This permits using the <locale> header with newlib or picolibc when LIBCXX_ENABLE_WIDE_CHARACTERS=FALSE.

Since D136682 the __support/xlocale headers themselves include the headers they require, respecting the LIBCXX_ENABLE_WIDE_CHARACTERS option.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2022, 6:33 AM
michaelplatings requested review of this revision.Oct 28 2022, 6:33 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2022, 6:33 AM
philnik accepted this revision.Oct 28 2022, 6:47 AM
philnik added a subscriber: philnik.

LGTM if you make sure locally that it builds properly. We don't have a newlib configuration in the CI right now.

This revision is now accepted and ready to land.Oct 28 2022, 6:47 AM

Thanks Nikolas for the quick review

We don't have a newlib configuration in the CI right now.

@philnik I'd therefore be interested to get your views on https://discourse.llvm.org/t/rfc-testing-of-newlib-picolibc/66509