This is an archive of the discontinued LLVM Phabricator instance.

[Headers] remove define of _GNU_SOURCE when including Darwin's unwind.h
Needs ReviewPublic

Authored by mhjacobson on Oct 23 2022, 11:02 PM.

Details

Reviewers
chandlerc
Summary

Darwin's unwind.h has never surrounded declarations with _GNU_SOURCE guards.
The _GNU_SOURCE stuff removed here was introduced by a09e62a042, which expanded
the #include_next branch to non-Darwin platforms, including those that use
https://github.com/libunwind/libunwind (which *does* use _GNU_SOURCE guards).
That change was partially reverted by 032d422d2e, which left the _GNU_SOURCE
stuff as an "open question".

Therefore: close the question; remove the _GNU_SOURCE define.

Diff Detail

Event Timeline

mhjacobson created this revision.Oct 23 2022, 11:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2022, 11:02 PM
mhjacobson requested review of this revision.Oct 23 2022, 11:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2022, 11:02 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript