This is an archive of the discontinued LLVM Phabricator instance.

Differential D136276

[libc++][CI] Reorder jobs.
ClosedPublic

Authored by Mordante on Oct 19 2022, 11:08 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG37fc37dd5d49: [libc++][CI] Reorder jobs.
Summary

In the second leg of the CI the steps take about:

  • C++2b 10m
  • C++11 8m
  • C++03 6m
  • Modular build 10m
  • GCC 12 / C++latest 20m

So the slowest job is scheduled last. The CI will wait to start the
third leg until that job is done. The current order increases the
latency of the current job, instead start the slow jobs earlier.

Diff Detail

Event Timeline

Mordante created this revision.Oct 19 2022, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 11:08 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Oct 19 2022, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 11:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne accepted this revision.Oct 19 2022, 6:50 PM
This revision is now accepted and ready to land.Oct 19 2022, 6:50 PM
Harbormaster completed remote builds in B193051: Diff 468982.Oct 19 2022, 10:56 PM
Closed by commit rG37fc37dd5d49: [libc++][CI] Reorder jobs. (authored by Mordante). · Explain WhyOct 20 2022, 8:28 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG37fc37dd5d49: [libc++][CI] Reorder jobs..

Revision Contents

PathSize
libcxx/
utils/
ci/
28 lines

Diff 469240

libcxx/utils/ci/buildkite-pipeline.yml

Show First 20 Lines • Show All 73 Lines • ▼ Show 20 Linessteps:
# #
# General testing with the default configuration, under all the supported # General testing with the default configuration, under all the supported
# Standard modes, with Clang and GCC. This catches most issues upfront. # Standard modes, with Clang and GCC. This catches most issues upfront.
# The goal of this step is to catch most issues while being very fast. # The goal of this step is to catch most issues while being very fast.
# #
- wait - wait
- label: "C++2b" - label: "GCC ${GCC_STABLE_VERSION} / C++latest"
command: "libcxx/utils/ci/run-buildbot generic-cxx2b" command: "libcxx/utils/ci/run-buildbot generic-gcc"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
- "**/*.abilist" - "**/*.abilist"
env: env:
CC: "clang-${LLVM_HEAD_VERSION}" CC: "gcc-${GCC_STABLE_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}" CXX: "g++-${GCC_STABLE_VERSION}"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "C++11" - label: "C++2b"
command: "libcxx/utils/ci/run-buildbot generic-cxx11" command: "libcxx/utils/ci/run-buildbot generic-cxx2b"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
- "**/*.abilist" - "**/*.abilist"
env: env:
CC: "clang-${LLVM_HEAD_VERSION}" CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "C++03" - label: "Modular build"
command: "libcxx/utils/ci/run-buildbot generic-cxx03" command: "libcxx/utils/ci/run-buildbot generic-modules"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
- "**/*.abilist" - "**/*.abilist"
env: env:
CC: "clang-${LLVM_HEAD_VERSION}" CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "Modular build" - label: "C++11"
command: "libcxx/utils/ci/run-buildbot generic-modules" command: "libcxx/utils/ci/run-buildbot generic-cxx11"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
- "**/*.abilist" - "**/*.abilist"
env: env:
CC: "clang-${LLVM_HEAD_VERSION}" CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "GCC ${GCC_STABLE_VERSION} / C++latest" - label: "C++03"
command: "libcxx/utils/ci/run-buildbot generic-gcc" command: "libcxx/utils/ci/run-buildbot generic-cxx03"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
- "**/*.abilist" - "**/*.abilist"
env: env:
CC: "gcc-${GCC_STABLE_VERSION}" CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "g++-${GCC_STABLE_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
▲ Show 20 Lines • Show All 788 Lines • Show Last 20 Lines