[llvm-reduce] Reduce comdats

[arsenm]

llvm/test/tools/llvm-reduce/remove-comdat.ll

6

Maybe should have a check where one of them is needed

llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp

30–31

Don't understand what this would do

[aeubanks]

update test
remove unintended code

llvm/test/tools/llvm-reduce/remove-comdat.ll

+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=global-objects --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefix=CHECK-FINAL %s --input-file=%t
+
+; CHECK-INTERESTINGNESS: define void @f
+; CHECK-INTERESTINGNESS: define void @g
+; CHECK-INTERESTINGNESS: define void @i{{.*}} comdat
+
+; CHECK-FINAL-NOT: $f
+; CHECK-FINAL-NOT: $h
+; CHECK-FINAL: $i = comdat
+; CHECK-FINAL: define void @f() {
+; CHECK-FINAL: define void @g() {
+; CHECK-FINAL: define void @i() comdat {
+
+$f = comdat any
+$h = comdat any
+$i = comdat any
+
+define void @f() comdat {
+  ret void
+}
+
+define void @g() comdat($h) {
+  ret void
+}
+
+define void @i() comdat {
+  ret void
+}

llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp

 using namespace llvm;
 
 static bool shouldReduceSection(GlobalObject &GO) { return GO.hasSection(); }
 
 static bool shouldReduceAlign(GlobalObject &GO) {
   return GO.getAlign().has_value();
 }
 
+static bool shouldReduceComdat(GlobalObject &GO) { return GO.hasComdat(); }
+
 static void reduceGOs(Oracle &O, Module &Program) {
   for (auto &GO : Program.global_objects()) {
     if (shouldReduceSection(GO) && !O.shouldKeep())
       GO.setSection("");
     if (shouldReduceAlign(GO) && !O.shouldKeep())
       GO.setAlignment(MaybeAlign());
+    if (shouldReduceComdat(GO) && !O.shouldKeep())
+      GO.setComdat(nullptr);
   }
 }
 
 void llvm::reduceGlobalObjectsDeltaPass(TestRunner &Test) {
   outs() << "*** Reducing GlobalObjects...\n";
   runDeltaPass(Test, reduceGOs);
 }