This is an archive of the discontinued LLVM Phabricator instance.

Summary:
Needs ReviewPublic

Authored by HenriqueBucher on Oct 10 2022, 11:20 AM.

Details

Summary

Reformatted doc text so it is more or less around 80 columns limit - in markdown equivalent.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2022, 11:20 AM
HenriqueBucher requested review of this revision.Oct 10 2022, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2022, 11:20 AM

I am not sure how and if any of these changes will affect the output. Any chance we can attach a before and after screenshot of the rendered output?

lldb/tools/lldb-vscode/README.md
18–19

Should these two lines have been combined?

To be frank, I think this formatting is silly and wrong now that I am looking at it.
Looking at the rendered markdown at Github you can see that the browser itself word wraps for you to the allocated width.
There is no need to break down manually.
However if you break down inside the tables it will break the syntax of markdown tables.
And the wrapping does not affect at all the output on the web.
I'd say delete this patch and forget about this 80 column limit.
But it's up to you, I'm here just as a helper.

To be frank, I think this formatting is silly and wrong now that I am looking at it.
Looking at the rendered markdown at Github you can see that the browser itself word wraps for you to the allocated width.
There is no need to break down manually.
However if you break down inside the tables it will break the syntax of markdown tables.

Yes, this is an example where you have to exceed the 80 column limit.

And the wrapping does not affect at all the output on the web.

That's correct, the 80 column limit is not a technical limitation, but rather a coding documentation style one. If you take a look at the other docs you'll notice everything is using the 80 column limit.

I'd say delete this patch and forget about this 80 column limit.
But it's up to you, I'm here just as a helper.