This is an archive of the discontinued LLVM Phabricator instance.

Differential D135533

[DSE][NFC] Add nounwind attribute to match test intent
ClosedPublic

Authored by StephenFan on Oct 8 2022, 10:57 PM.

Details

Reviewers
nikic
Commits
rG4de58eb432b6: [DSE][NFC] Add nounwind attribute to match test intent

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

StephenFan created this revision.Oct 8 2022, 10:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2022, 10:57 PM
StephenFan requested review of this revision.Oct 8 2022, 10:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2022, 10:57 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B191153: Diff 466350.Oct 9 2022, 12:26 AM
nikic accepted this revision.Oct 9 2022, 1:12 AM

LGTM

This revision is now accepted and ready to land.Oct 9 2022, 1:12 AM
This revision was landed with ongoing or failed builds.Oct 9 2022, 9:12 AM
Closed by commit rG4de58eb432b6: [DSE][NFC] Add nounwind attribute to match test intent (authored by StephenFan). · Explain Why
This revision was automatically updated to reflect the committed changes.
StephenFan added a commit: rG4de58eb432b6: [DSE][NFC] Add nounwind attribute to match test intent.

Revision Contents

PathSize
llvm/
test/
Transforms/
DeadStoreElimination/
9 lines

Diff 466350

llvm/test/Transforms/DeadStoreElimination/multiblock-loops.ll

Show First 20 Lines • Show All 386 Lines • ▼ Show 20 Linesbb2:
%c1 = icmp slt i32 %ph, 10 %c1 = icmp slt i32 %ph, 10
br i1 %c1, label %bb1, label %exit br i1 %c1, label %bb1, label %exit
exit: exit:
%pg = getelementptr inbounds i32, ptr %p, i32 %i %pg = getelementptr inbounds i32, ptr %p, i32 %i
%l = load i32, ptr %pg %l = load i32, ptr %pg
ret i32 %l ret i32 %l
} }
declare i1 @cond() readnone declare i1 @cond() readnone nounwind
; TODO: We can eliminate the store in for.header, but we currently hit a MemoryPhi.
define void @loop_multiple_def_uses(ptr noalias %P) { define void @loop_multiple_def_uses(ptr noalias %P) {
; CHECK-LABEL: @loop_multiple_def_uses( ; CHECK-LABEL: @loop_multiple_def_uses(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: br label [[FOR_HEADER:%.*]] ; CHECK-NEXT: br label [[FOR_HEADER:%.*]]
; CHECK: for.header: ; CHECK: for.header:
; CHECK-NEXT: store i32 1, ptr [[P:%.*]], align 4
; CHECK-NEXT: [[C1:%.*]] = call i1 @cond() ; CHECK-NEXT: [[C1:%.*]] = call i1 @cond()
; CHECK-NEXT: br i1 [[C1]], label [[FOR_BODY:%.*]], label [[END:%.*]] ; CHECK-NEXT: br i1 [[C1]], label [[FOR_BODY:%.*]], label [[END:%.*]]
; CHECK: for.body: ; CHECK: for.body:
; CHECK-NEXT: store i32 2, ptr [[P]], align 4 ; CHECK-NEXT: store i32 2, ptr [[P:%.*]], align 4
; CHECK-NEXT: [[LV:%.*]] = load i32, ptr [[P]], align 4 ; CHECK-NEXT: [[LV:%.*]] = load i32, ptr [[P]], align 4
; CHECK-NEXT: br label [[FOR_HEADER]] ; CHECK-NEXT: br label [[FOR_HEADER]]
; CHECK: end: ; CHECK: end:
; CHECK-NEXT: store i32 3, ptr [[P]], align 4 ; CHECK-NEXT: store i32 3, ptr [[P]], align 4
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
; ;
entry: entry:
br label %for.header br label %for.header
Show All 15 Lines
; We cannot eliminate the store in for.header, as it is only partially ; We cannot eliminate the store in for.header, as it is only partially
; overwritten in for.body and read afterwards. ; overwritten in for.body and read afterwards.
define void @loop_multiple_def_uses_partial_write(ptr noalias %p) { define void @loop_multiple_def_uses_partial_write(ptr noalias %p) {
; CHECK-LABEL: @loop_multiple_def_uses_partial_write( ; CHECK-LABEL: @loop_multiple_def_uses_partial_write(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: br label [[FOR_HEADER:%.*]] ; CHECK-NEXT: br label [[FOR_HEADER:%.*]]
; CHECK: for.header: ; CHECK: for.header:
; CHECK-NEXT: store i32 1239491, ptr [[P:%.*]], align 4 ; CHECK-NEXT: store i32 1239297, ptr [[P:%.*]], align 4
; CHECK-NEXT: [[C1:%.*]] = call i1 @cond() ; CHECK-NEXT: [[C1:%.*]] = call i1 @cond()
; CHECK-NEXT: br i1 [[C1]], label [[FOR_BODY:%.*]], label [[END:%.*]] ; CHECK-NEXT: br i1 [[C1]], label [[FOR_BODY:%.*]], label [[END:%.*]]
; CHECK: for.body: ; CHECK: for.body:
; CHECK-NEXT: store i8 1, ptr [[P]], align 4
; CHECK-NEXT: [[LV:%.*]] = load i32, ptr [[P]], align 4 ; CHECK-NEXT: [[LV:%.*]] = load i32, ptr [[P]], align 4
; CHECK-NEXT: br label [[FOR_HEADER]] ; CHECK-NEXT: br label [[FOR_HEADER]]
; CHECK: end: ; CHECK: end:
; CHECK-NEXT: store i32 3, ptr [[P]], align 4 ; CHECK-NEXT: store i32 3, ptr [[P]], align 4
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
; ;
entry: entry:
br label %for.header br label %for.header
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines