This is an archive of the discontinued LLVM Phabricator instance.

Differential D135325

[CMake] cmake cache for hexagon libc++{,abi} + libunwind
AbandonedPublic

Authored by ldionne on Oct 5 2022, 3:08 PM.

Details

Reviewers
phosek
bcain
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

bcain created this revision.Oct 5 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 3:08 PM
bcain requested review of this revision.Oct 5 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 3:08 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B190615: Diff 465570.Oct 5 2022, 5:42 PM
ldionne added inline comments.Dec 20 2022, 3:53 PM
libcxx/cmake/caches/hexagon-linux-cxx17.cmake
2–3

Same here, it's a bit unusual to hardcode this in these caches. We only do it for the Generic-XXXXX caches since those are basically only used for the CI. I think it would make more sense to leave this unspecified by this cache.

4

Are we mis-detecting this? If so, it would be best to fix it instead of hardcoding the value in this cache.

23

It's a bit unusual to encode something like this in these caches, since they should be about customizing libc++/libc++abi/libunwind specific knobs. WDYT?

ldionne requested changes to this revision.Dec 20 2022, 3:53 PM

Requesting changes for the queue.

This revision now requires changes to proceed.Dec 20 2022, 3:53 PM
ldionne commandeered this revision.Aug 31 2023, 12:33 PM
ldionne edited reviewers, added: bcain; removed: ldionne.

[Github PR transition cleanup]

I'll close this review since it has been inactive for a while and we're clearing the review queue for the move to PRs. Please reopen as a PR if you're still interested in doing this.

Herald added a subscriber: ekilmer. · View Herald TranscriptAug 31 2023, 12:33 PM
ldionne abandoned this revision.Aug 31 2023, 12:33 PM

Revision Contents

PathSize
libcxx/
cmake/
caches/
23 lines

Diff 465570

libcxx/cmake/caches/hexagon-linux-cxx17.cmake

  • This file was added.
set(LIBCXX_TEST_PARAMS "std=c++17" CACHE STRING "")
set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")
ldionneAuthorUnsubmitted
Not Done
ReplyInline Actions

Same here, it's a bit unusual to hardcode this in these caches. We only do it for the Generic-XXXXX caches since those are basically only used for the CI. I think it would make more sense to leave this unspecified by this cache.

ldionne: Same here, it's a bit unusual to hardcode this in these caches. We only do it for the `Generic…
set(LIBCXX_HAS_GCC_S_LIB OFF CACHE BOOL "")
ldionneAuthorUnsubmitted
Not Done
ReplyInline Actions

Are we mis-detecting this? If so, it would be best to fix it instead of hardcoding the value in this cache.

ldionne: Are we mis-detecting this? If so, it would be best to fix it instead of hardcoding the value in…
set(LIBCXX_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "")
set(LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXX_INSTALL_STATIC_LIBRARY ON CACHE BOOL "")
set(LIBCXXABI_INSTALL_STATIC_LIBRARY ON CACHE BOOL "")
set(LIBUNWIND_INSTALL_STATIC_LIBRARY ON CACHE BOOL "")
set(LIBCXX_INSTALL_SHARED_LIBRARY ON CACHE BOOL "")
set(LIBCXXABI_INSTALL_SHARED_LIBRARY ON CACHE BOOL "")
set(LIBUNWIND_INSTALL_SHARED_LIBRARY ON CACHE BOOL "")
set(UNIX ON CACHE BOOL "")
ldionneAuthorUnsubmitted
Not Done
ReplyInline Actions

It's a bit unusual to encode something like this in these caches, since they should be about customizing libc++/libc++abi/libunwind specific knobs. WDYT?

ldionne: It's a bit unusual to encode something like this in these caches, since they should be about…