This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++][format] Improves tests.
ClosedPublic

Authored by Mordante on Oct 5 2022, 10:24 AM.

Details

Reviewers
ldionne
vitaut
Group Reviewers
Restricted Project
Commits
rG6195bdb9f13b: [NFC][libc++][format] Improves tests.
Summary

This is mainly to improve the readability of the tests. As a side
effects the tests run faster too,

Diff Detail

Event Timeline

Mordante created this revision.Oct 5 2022, 10:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2022, 10:24 AM
Mordante updated this revision to Diff 466370.Oct 9 2022, 6:16 AM

Readd accidentally removed code.

Mordante published this revision for review.Oct 9 2022, 7:42 AM
Mordante added reviewers: ldionne, vitaut.
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2022, 7:42 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Oct 11 2022, 9:31 AM
ldionne added inline comments.
libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp
34

Here and elsewhere.

libcxx/test/std/utilities/format/format.functions/format_tests.h
188–189
This revision is now accepted and ready to land.Oct 11 2022, 9:31 AM
Mordante marked 2 inline comments as done.Oct 11 2022, 10:23 AM
Mordante added inline comments.
libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp
34

Nice catch, these is due to clang-format's C++03 compatibility.

This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.
libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp