When llvm-symbolizer is passed a list of address, its nice to have an option which will print address corresponding line information. This improves human readability.
Please see http://llvm.org/docs/Phabricator.html on how to upload patches with more context.
I don't understand why you need to pass the value of "-address" option down to LLVMSymbolizer class - you can just handle it inside main(). I would also prefer option name to be more verbose like "-print-address".
|1 ↗||(On Diff #36755)|
Where did you get addr.exe from? I'd prefer to either use existing executable file, or commit the source file with description of build procedure. (the former is better).