Page MenuHomePhabricator

khemant (khemant@codeaurora.org)
User

Projects

User Details

User Since
Oct 1 2012, 3:20 PM (328 w, 4 d)

Recent Activity

Jul 17 2017

khemant added a comment to D33909: Allow EXIDX information display using llvm-readobj for executables.

Does obj2yaml support generating YAML from executables? Last time I checked it did not. This change only relates to executable.

Jul 17 2017, 12:06 PM

Jun 5 2017

khemant created D33909: Allow EXIDX information display using llvm-readobj for executables.
Jun 5 2017, 12:50 PM

Dec 27 2016

khemant committed rL290623: llvm-readobj: ELF: Make DT tags machine aware.
llvm-readobj: ELF: Make DT tags machine aware
Dec 27 2016, 12:10 PM
khemant added inline comments to D28127: ELF: Make dynamic table tags machine aware..
Dec 27 2016, 11:51 AM
khemant added a reviewer for D28127: ELF: Make dynamic table tags machine aware.: compnerd.
Dec 27 2016, 11:31 AM
khemant retitled D28127: ELF: Make dynamic table tags machine aware. from to ELF: Make dynamic table tags machine aware..
Dec 27 2016, 11:31 AM

Nov 23 2016

khemant committed rL287786: llvm-readobj: Use hash tables to print dynamic symbols..
llvm-readobj: Use hash tables to print dynamic symbols.
Nov 23 2016, 10:14 AM

Nov 14 2016

khemant added a comment to rL286556: llvm-strings: introduce basic strings tool.

Thanks for doing this.

Nov 14 2016, 9:00 AM

Sep 16 2016

khemant added a comment to D24636: llvm-objdump Allow disassembly of ARM and thumb code mix in ELF object file..

The first thing I would say is that it really needs a clang-format pass as well as a lot more tests, since the change in functionality is not small.

This was clang-formatted, may be my clang format python script is old.

Sep 16 2016, 9:50 AM

Sep 15 2016

khemant added inline comments to D24636: llvm-objdump Allow disassembly of ARM and thumb code mix in ELF object file..
Sep 15 2016, 3:10 PM
khemant retitled D24636: llvm-objdump Allow disassembly of ARM and thumb code mix in ELF object file. from to llvm-objdump Allow disassembly of ARM and thumb code mix in ELF object file..
Sep 15 2016, 3:08 PM

Sep 12 2016

khemant committed rL281240: Fix test failure in r281232.
Fix test failure in r281232
Sep 12 2016, 10:48 AM
khemant committed rL281233: llvm-size: Add --totals option.
llvm-size: Add --totals option
Sep 12 2016, 10:17 AM
khemant committed rL281232: llvm-objdump: Add --start-address and --stop-address options.
llvm-objdump: Add --start-address and --stop-address options
Sep 12 2016, 10:17 AM
khemant closed D24308: llvm-size: Add --totals option by committing rL281233: llvm-size: Add --totals option.
Sep 12 2016, 10:17 AM
khemant closed D24160: llvm-objdump: Implement --start-address and --stop-address by committing rL281232: llvm-objdump: Add --start-address and --stop-address options.
Sep 12 2016, 10:17 AM

Sep 8 2016

khemant added a comment to D24160: llvm-objdump: Implement --start-address and --stop-address.

ping..

Sep 8 2016, 3:54 PM

Sep 7 2016

khemant retitled D24308: llvm-size: Add --totals option from to llvm-size: Add --totals option.
Sep 7 2016, 12:31 PM

Sep 6 2016

khemant added a comment to D24160: llvm-objdump: Implement --start-address and --stop-address.
Sep 6 2016, 2:38 PM
khemant updated the diff for D24160: llvm-objdump: Implement --start-address and --stop-address.

Made test case a yaml instead of binary.

Sep 6 2016, 2:37 PM

Sep 2 2016

khemant added inline comments to D24160: llvm-objdump: Implement --start-address and --stop-address.
Sep 2 2016, 9:37 AM

Sep 1 2016

khemant retitled D24160: llvm-objdump: Implement --start-address and --stop-address from to llvm-objdump: Implement --start-address and --stop-address.
Sep 1 2016, 2:54 PM

Aug 30 2016

khemant committed rL280152: Revert "ELFDumper: Unversioned symbols must not have trailing @".
Revert "ELFDumper: Unversioned symbols must not have trailing @"
Aug 30 2016, 1:51 PM
khemant committed rL280140: ELFDumper: Unversioned symbols must not have trailing @.
ELFDumper: Unversioned symbols must not have trailing @
Aug 30 2016, 12:58 PM

Aug 25 2016

khemant committed rL279775: Fix test corresponding to change r279770.
Fix test corresponding to change r279770
Aug 25 2016, 1:51 PM
khemant committed rL279770: llvm-objdump: ELF: Handle code and data mix in all scenarios.
llvm-objdump: ELF: Handle code and data mix in all scenarios
Aug 25 2016, 12:49 PM
khemant closed D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios by committing rL279770: llvm-objdump: ELF: Handle code and data mix in all scenarios.
Aug 25 2016, 12:49 PM

Aug 24 2016

khemant added inline comments to D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios.
Aug 24 2016, 10:21 AM

Aug 23 2016

khemant updated the diff for D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios.

Updated diff with latest tip, made few changes as recommended.

Aug 23 2016, 3:14 PM
khemant added inline comments to D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios.
Aug 23 2016, 2:47 PM
khemant added inline comments to D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios.
Aug 23 2016, 1:48 PM

Aug 18 2016

khemant committed rL279161: llvm-objdump: Add Hexagon printer changes for -S/-l options.
llvm-objdump: Add Hexagon printer changes for -S/-l options
Aug 18 2016, 2:58 PM
khemant closed D23521: llvm-objdump: Hexagon: Add source interleave test. by committing rL279161: llvm-objdump: Add Hexagon printer changes for -S/-l options.
Aug 18 2016, 2:58 PM
khemant closed D22932: Implement llvm-objdump -S and -l.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@278725 91177308-0d34-0410-b5e6-96231b3b80d8

Aug 18 2016, 12:27 PM
khemant added a comment to D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios.
Aug 18 2016, 10:15 AM
khemant updated the diff for D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios.

Incorporated suggestions from previous diff.
Added ARM test.

Aug 18 2016, 10:15 AM
khemant added inline comments to D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios.
Aug 18 2016, 9:23 AM

Aug 17 2016

khemant added a comment to D23521: llvm-objdump: Hexagon: Add source interleave test..

Ping!

Aug 17 2016, 2:43 PM
khemant retitled D23621: llvm-objdump: ELF: Handle code and data mix in all scenarios from to llvm-objdump: ELF: Handle code and data mix in all scenarios.
Aug 17 2016, 12:31 PM

Aug 15 2016

khemant committed rL278748: Really fix the issue with 502957cc9cf805dc6093950e8cdcd0db4969d933. Windows….
Really fix the issue with 502957cc9cf805dc6093950e8cdcd0db4969d933. Windows…
Aug 15 2016, 2:46 PM
khemant committed rL278732: Fix a test that failed due to:.
Fix a test that failed due to:
Aug 15 2016, 1:44 PM
khemant retitled D23521: llvm-objdump: Hexagon: Add source interleave test. from to llvm-objdump: Hexagon: Add source interleave test..
Aug 15 2016, 1:03 PM
khemant committed rL278725: llvm-objdump: Implement source[line numbers] interleaving.
llvm-objdump: Implement source[line numbers] interleaving
Aug 15 2016, 12:57 PM

Aug 12 2016

khemant added a reviewer for D22932: Implement llvm-objdump -S and -l: compnerd.
Aug 12 2016, 12:50 PM
khemant added a comment to D22932: Implement llvm-objdump -S and -l.

@compnerd. You are right, IR is better choice for test. Formatted the test too. Please +1 the change.

Aug 12 2016, 11:59 AM
khemant updated the diff for D22932: Implement llvm-objdump -S and -l.

The test is now IR instead of asm. clang formatted the test.

Aug 12 2016, 11:58 AM

Aug 11 2016

khemant added a comment to D22932: Implement llvm-objdump -S and -l.

@compnerd: Please review the changes. Took your suggestions into account.

Aug 11 2016, 3:22 PM
khemant updated the diff for D22932: Implement llvm-objdump -S and -l.

Removed hexagon changes to leave only generic pretty printer changes. Hexagon will be added as a separate patch.

Aug 11 2016, 3:20 PM

Aug 10 2016

khemant added a comment to D22932: Implement llvm-objdump -S and -l.

I think it would be better to split the hexagon support into a separate (trivial) patch. That would make this change only add the source and line number printing and tests for x86. The hexagon change would then add that target as well.

Aug 10 2016, 11:40 AM

Aug 9 2016

khemant added a comment to D22932: Implement llvm-objdump -S and -l.

ping!

Aug 9 2016, 3:48 PM

Aug 5 2016

khemant updated the diff for D22932: Implement llvm-objdump -S and -l.

Made changes so all pretty printers can interleave source with disassembly. Added tests that test X86 and Hexagon printers.

Aug 5 2016, 1:46 PM

Jul 29 2016

khemant added a comment to D22932: Implement llvm-objdump -S and -l.

Thanks. Will try that an send for review.

Jul 29 2016, 9:40 AM

Jul 28 2016

khemant retitled D22932: Implement llvm-objdump -S and -l from to Implement llvm-objdump -S and -l.
Jul 28 2016, 1:15 PM

May 12 2016

khemant committed rL269376: llvm-readobj: Fix GNU style entry point print width.
llvm-readobj: Fix GNU style entry point print width
May 12 2016, 3:57 PM
khemant committed rL269368: llvm-readobj: Change Hex output for GNU style dynamic table print.
llvm-readobj: Change Hex output for GNU style dynamic table print
May 12 2016, 3:23 PM
khemant committed rL269338: llvm-readobj: Fix the GNU section header flags for SHF_MASKPROC and SHF_MASKOS.
llvm-readobj: Fix the GNU section header flags for SHF_MASKPROC and SHF_MASKOS
May 12 2016, 1:05 PM

Apr 26 2016

khemant accepted D19429: Give backends an opportunity to finish layout post-relaxation.
Apr 26 2016, 9:34 AM

Apr 11 2016

khemant committed rL265967: [llvm-readobj] Add ELF hash histogram printing.
[llvm-readobj] Add ELF hash histogram printing
Apr 11 2016, 10:21 AM
khemant closed D18907: Print ELF hash histogram by committing rL265967: [llvm-readobj] Add ELF hash histogram printing.
Apr 11 2016, 10:21 AM

Apr 8 2016

khemant added a comment to D18907: Print ELF hash histogram.

Thanks for the reminder :)

Apr 8 2016, 1:19 PM
khemant retitled D18907: Print ELF hash histogram from to Print ELF hash histogram.
Apr 8 2016, 1:08 PM

Mar 29 2016

khemant committed rL264731: [llvm-readobj] NFC: Remove unneeded parenthesis.
[llvm-readobj] NFC: Remove unneeded parenthesis
Mar 29 2016, 7:25 AM

Mar 28 2016

khemant committed rL264693: [llvm-readobj] Support GNU style dyn-relocations.
[llvm-readobj] Support GNU style dyn-relocations
Mar 28 2016, 7:47 PM
khemant added a comment to D18534: Support dynamic relocation printing in GNU style.

I am pushing this in as there is not a major design here. Just adding something that fell through the cracks when implementing other relocation printing method.

Mar 28 2016, 5:33 PM
khemant retitled D18534: Support dynamic relocation printing in GNU style from to Support dynamic relocation printing in GNU style.
Mar 28 2016, 5:30 PM
khemant committed rL264595: [llvm-readobj] NFC Replace case by macros for PT_* enums.
[llvm-readobj] NFC Replace case by macros for PT_* enums
Mar 28 2016, 10:25 AM
khemant committed rL264591: [llvm-size] Implement --common option.
[llvm-size] Implement --common option
Mar 28 2016, 9:53 AM
khemant closed D16820: Implement common symbol size calculation in llvm-size by committing rL264591: [llvm-size] Implement --common option.
Mar 28 2016, 9:53 AM

Mar 25 2016

khemant committed rL264419: Fix Narrowing conversion warning introduced by r264415.
Fix Narrowing conversion warning introduced by r264415
Mar 25 2016, 9:42 AM
khemant committed rL264415: [llvm-readobj] Impl GNU style program headers print.
[llvm-readobj] Impl GNU style program headers print
Mar 25 2016, 9:10 AM
khemant closed D18372: llvm-readobj: Print GNU style program headers by committing rL264415: [llvm-readobj] Impl GNU style program headers print.
Mar 25 2016, 9:10 AM

Mar 23 2016

khemant added a comment to D16820: Implement common symbol size calculation in llvm-size.

ping

Mar 23 2016, 11:30 AM

Mar 22 2016

khemant added a comment to D18372: llvm-readobj: Print GNU style program headers.
Mar 22 2016, 1:17 PM
khemant updated the diff for D18372: llvm-readobj: Print GNU style program headers.

Updated test.

Mar 22 2016, 1:17 PM
khemant added inline comments to D18372: llvm-readobj: Print GNU style program headers.
Mar 22 2016, 1:09 PM
khemant added a comment to D18372: llvm-readobj: Print GNU style program headers.

test/tools/llvm-readobj/Inputs/phdrs-elf.exe-* files are checked in as Binary as they are fully formed executables. They also have sufficient mix of program headers which have TLS sections in permissible segments and some extra non PT_LOAD segments.

Mar 22 2016, 1:09 PM
khemant retitled D18372: llvm-readobj: Print GNU style program headers from to llvm-readobj: Print GNU style program headers.
Mar 22 2016, 1:07 PM

Mar 21 2016

khemant accepted D15965: Add support for dumping relocations in non-relocatable files.

LGTM.

Mar 21 2016, 11:16 AM
khemant added a comment to D18224: llvm-readobj: GNU style symbols printing.
Mar 21 2016, 10:27 AM
khemant committed rL263952: [llvm-readobj] Impl GNU style symbols printing.
[llvm-readobj] Impl GNU style symbols printing
Mar 21 2016, 10:23 AM
khemant closed D18224: llvm-readobj: GNU style symbols printing by committing rL263952: [llvm-readobj] Impl GNU style symbols printing.
Mar 21 2016, 10:23 AM

Mar 18 2016

khemant added a comment to D18224: llvm-readobj: GNU style symbols printing.
Mar 18 2016, 12:42 PM
khemant updated the diff for D18224: llvm-readobj: GNU style symbols printing.

Incorporated the comments.

Mar 18 2016, 12:41 PM

Mar 17 2016

khemant added inline comments to D18224: llvm-readobj: GNU style symbols printing.
Mar 17 2016, 4:26 PM
khemant added a comment to D18224: llvm-readobj: GNU style symbols printing.

The patch to upstream the processor specific flags for small area is not yet in the Hexagon backend. That is why I made a binary. I do not know of other backends that can get me this flag.

Mar 17 2016, 3:39 PM
khemant added a reviewer for D15965: Add support for dumping relocations in non-relocatable files: khemant.
Mar 17 2016, 2:29 PM
khemant updated subscribers of D15965: Add support for dumping relocations in non-relocatable files.
Mar 17 2016, 2:29 PM

Mar 16 2016

khemant updated the diff for D18224: llvm-readobj: GNU style symbols printing.

Added test case.

Mar 16 2016, 1:47 PM
khemant added a comment to D18224: llvm-readobj: GNU style symbols printing.

Looks like I forgot to add the test case. Will update the diff.

Mar 16 2016, 1:43 PM
khemant retitled D18224: llvm-readobj: GNU style symbols printing from to llvm-readobj: GNU style symbols printing.
Mar 16 2016, 1:42 PM

Mar 15 2016

khemant committed rL263561: [llvm-readobj] Impl GNU style printing of sections and relocations.
[llvm-readobj] Impl GNU style printing of sections and relocations
Mar 15 2016, 10:30 AM
khemant closed D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files by committing rL263561: [llvm-readobj] Impl GNU style printing of sections and relocations.
Mar 15 2016, 10:30 AM

Mar 9 2016

khemant added a comment to D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.

ping.

Mar 9 2016, 3:20 PM
khemant committed rL263050: [llvm-readobj] Enable GNU style section group print.
[llvm-readobj] Enable GNU style section group print
Mar 9 2016, 11:21 AM
khemant closed D17822: llvm-readobj: enable GNU style -g option by committing rL263050: [llvm-readobj] Enable GNU style section group print.
Mar 9 2016, 11:21 AM

Mar 8 2016

khemant added a comment to D16820: Implement common symbol size calculation in llvm-size.

I will make the blakent style change after this patch. For now I am making the changes you mentioned.

Mar 8 2016, 1:25 PM
khemant added a comment to D16820: Implement common symbol size calculation in llvm-size.
Mar 8 2016, 1:23 PM
khemant updated the diff for D16820: Implement common symbol size calculation in llvm-size.

Addressed comments

Mar 8 2016, 1:22 PM
khemant added a comment to D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.
Mar 8 2016, 11:10 AM
khemant updated the diff for D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.

Use AltName for section type string.

Mar 8 2016, 11:07 AM