This is an archive of the discontinued LLVM Phabricator instance.

[lldb][test] Skip import-std-module/vector tests
ClosedPublic

Authored by Michael137 on Oct 4 2022, 9:58 AM.

Details

Summary

These tests have begun failing starting with commit
69a6417406a1b0316a1fa6aeb63339d0e1d2abbd, which
added a new import to ASTNodeImporter::VisitTypedefType.
This trips an assertion in following way:

  1. When creating a persistent variable for the result we call CopyType (in DeportType) under a CompleteTagDeclsScope (which is supposed to complete all decls newly imported in the CopyType call).
  2. During CopyType we call ASTNodeImporter::VisitTypedefType
  3. This now has a second import call on the desugared type
  4. In ASTImporterDelegate::ImportImpl we will now try to import a decl that no valid origin. But since we’re doing this under a CompleteTagDeclsScope, the NewDeclListener::NewDeclImported adds the decl to the list of decls to complete after the CopyType call. But this list shouldn’t contain decls with invalid origins because we assert this in ~CompleteTagDeclsScope, which is where the tests crash.

Skip this test for now until we have a fix or the origin tracking gets
refactored (see https://reviews.llvm.org/D101950).

Diff Detail

Event Timeline

Michael137 created this revision.Oct 4 2022, 9:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 9:58 AM
Michael137 requested review of this revision.Oct 4 2022, 9:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 9:58 AM
Michael137 edited the summary of this revision. (Show Details)Oct 4 2022, 10:05 AM
mib accepted this revision.Oct 4 2022, 10:14 AM
This revision is now accepted and ready to land.Oct 4 2022, 10:14 AM
aprantl accepted this revision.Oct 4 2022, 10:29 AM
This revision was automatically updated to reflect the committed changes.