This patch incorporates the "sanitize" step of the transitive includes
test into the CSV generator itself. In doing so, it removes complexity
in the test but also fixes a bug where we would filter out <__mutex>
from the output, leading to an incorrect list of includes for the
<shared_mutex> header.
Details
Details
- Reviewers
Mordante - Group Reviewers
Restricted Project - Commits
- rGc4ca3a2c4b00: [libc++] Simplify transitive includes test and fix a bug
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Rebase onto main, address comments.
libcxx/test/libcxx/transitive_includes_to_csv.py | ||
---|---|---|
147 | I actually moved it to inside parse_file, since IMO it made more sense to ensure that the output of parse_file itself had no duplicates. |
Comment Actions
Fix issue with sanitizers. The problem was that sanitizers cause additional headers to be included with -include, which broke the whole thing.