This is an archive of the discontinued LLVM Phabricator instance.

[lldb][test] 2 - Add gmodules test category explicitly where previously done implicitly
ClosedPublic

Authored by Michael137 on Sep 23 2022, 4:36 PM.

Details

Summary

Since we don't compile with gmodules implicitly via
debug-info test replication, we should mark all implicit
gmodules tests with the appropriate category so the API
tests get actually run as intended.

Diff Detail

Event Timeline

Michael137 created this revision.Sep 23 2022, 4:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2022, 4:36 PM
Michael137 requested review of this revision.Sep 23 2022, 4:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2022, 4:36 PM
  • Add decorator to another test
Michael137 retitled this revision from [lldb][test] 4 - Add gmodules test category explicitly where previously done implicitly to [lldb][test] 2 - Add gmodules test category explicitly where previously done implicitly.Sep 23 2022, 4:56 PM
aprantl accepted this revision.Sep 26 2022, 8:51 AM

Looks good!

This revision is now accepted and ready to land.Sep 26 2022, 8:51 AM