This is an archive of the discontinued LLVM Phabricator instance.

[BranchProbabilityInfo] Fixed contradiction between isEdgeHot() docs using >= 80% and code using > 80%
Needs ReviewPublic

Authored by agamkohli9 on Sep 22 2022, 2:28 PM.

Details

Reviewers
dexonsmith
Summary

BranchProbabilityInfo::isEdgeHot() contradictions:

Doxygen: We define hot as having a relative probability >= 80%

Comment: // Hot probability is at least 4/5 = 80%

Code: return getEdgeProbability(Src, Dst) > BranchProbability(4, 5);

Event Timeline

agamkohli9 created this revision.Sep 22 2022, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 2:28 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
agamkohli9 requested review of this revision.Sep 22 2022, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2022, 2:28 PM
agamkohli9 edited the summary of this revision. (Show Details)Sep 22 2022, 2:32 PM
agamkohli9 added a reviewer: dexonsmith.