This is an archive of the discontinued LLVM Phabricator instance.

Differential D134332

[gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions
ClosedPublic

Authored by aeubanks on Sep 20 2022, 8:40 PM.

Details

Reviewers
thakis
Commits
rG0f19c603423e: [gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions
Summary

llvm_unreachable should properly error out if assertions are enabled.

Diff Detail

Event Timeline

aeubanks created this revision.Sep 20 2022, 8:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2022, 8:40 PM
aeubanks requested review of this revision.Sep 20 2022, 8:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2022, 8:40 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B187895: Diff 461783.Sep 20 2022, 8:41 PM
thakis accepted this revision.Sep 21 2022, 10:30 AM
This revision is now accepted and ready to land.Sep 21 2022, 10:30 AM
This revision was landed with ongoing or failed builds.Sep 21 2022, 10:35 AM
Closed by commit rG0f19c603423e: [gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG0f19c603423e: [gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions.
aeubanks added a reverting change: rGb8e71766c835: Revert "[gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when….Oct 10 2022, 3:21 PM

Revision Contents

PathSize
llvm/
utils/
gn/
secondary/
llvm/
include/
llvm/
Config/
7 lines

Diff 461944

llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

Show First 20 Lines • Show All 323 Lines • ▼ Show 20 Lines values = [
"LLVM_ENABLE_ZSTD=", "LLVM_ENABLE_ZSTD=",
"LLVM_FORCE_ENABLE_STATS=", "LLVM_FORCE_ENABLE_STATS=",
"LLVM_FORCE_USE_OLD_TOOLCHAIN=", "LLVM_FORCE_USE_OLD_TOOLCHAIN=",
"LLVM_HAS_ATOMICS=1", "LLVM_HAS_ATOMICS=1",
"LLVM_HAVE_TF_API=", "LLVM_HAVE_TF_API=",
"LLVM_HAVE_TFLITE=", "LLVM_HAVE_TFLITE=",
"LLVM_HOST_TRIPLE=$llvm_current_triple", "LLVM_HOST_TRIPLE=$llvm_current_triple",
"LLVM_NATIVE_ARCH=$native_target", "LLVM_NATIVE_ARCH=$native_target",
"LLVM_UNREACHABLE_OPTIMIZE=1",
"LLVM_USE_INTEL_JITEVENTS=", "LLVM_USE_INTEL_JITEVENTS=",
"LLVM_USE_OPROFILE=", "LLVM_USE_OPROFILE=",
"LLVM_USE_PERF=", "LLVM_USE_PERF=",
"LLVM_VERSION_MAJOR=$llvm_version_major", "LLVM_VERSION_MAJOR=$llvm_version_major",
"LLVM_VERSION_MINOR=$llvm_version_minor", "LLVM_VERSION_MINOR=$llvm_version_minor",
"LLVM_VERSION_PATCH=$llvm_version_patch", "LLVM_VERSION_PATCH=$llvm_version_patch",
"LLVM_WITH_Z3=", "LLVM_WITH_Z3=",
"PACKAGE_VERSION=${llvm_version}git", "PACKAGE_VERSION=${llvm_version}git",
] ]
if (llvm_enable_assertions) {
values += [ "LLVM_UNREACHABLE_OPTIMIZE=" ]
} else {
values += [ "LLVM_UNREACHABLE_OPTIMIZE=1" ]
}
if (llvm_build_native) { if (llvm_build_native) {
values += [ values += [
"LLVM_NATIVE_ASMPARSER=1", "LLVM_NATIVE_ASMPARSER=1",
"LLVM_NATIVE_ASMPRINTER=1", "LLVM_NATIVE_ASMPRINTER=1",
"LLVM_NATIVE_DISASSEMBLER=1", "LLVM_NATIVE_DISASSEMBLER=1",
"LLVM_NATIVE_TARGET=1", "LLVM_NATIVE_TARGET=1",
"LLVM_NATIVE_TARGETINFO=1", "LLVM_NATIVE_TARGETINFO=1",
"LLVM_NATIVE_TARGETMC=1", "LLVM_NATIVE_TARGETMC=1",
▲ Show 20 Lines • Show All 131 Lines • Show Last 20 Lines