This is an archive of the discontinued LLVM Phabricator instance.

Add verification for align, dereferenceable, dereferenceable_or_null load metadata
ClosedPublic

Authored by apilipenko on Oct 5 2015, 2:52 AM.

Diff Detail

Event Timeline

apilipenko updated this revision to Diff 36487.Oct 5 2015, 2:52 AM
apilipenko retitled this revision from to Add verification for align, dereferenceable, dereferenceable_or_null load metadata.
apilipenko updated this object.
apilipenko added a reviewer: hfinkel.
apilipenko added a subscriber: llvm-commits.
apilipenko abandoned this revision.Oct 5 2015, 4:04 AM
apilipenko reclaimed this revision.Oct 5 2015, 6:30 AM
apilipenko updated this revision to Diff 36511.

Verify required constraints, add tests.

reames accepted this revision.Oct 8 2015, 9:58 AM
reames added a reviewer: reames.
reames added a subscriber: reames.

LGTM w/minor comments addressed.

lib/IR/Verifier.cpp
3080

I might combine these last two checks into a single one, but minor.

3230

This message could be clearer. "Alignment is larger that implementation defined limit" maybe?

This revision is now accepted and ready to land.Oct 8 2015, 9:58 AM
This revision was automatically updated to reflect the committed changes.