Use MSVC-equivalents of attributes

[compnerd]

The NOINLINE and UNUSED should be moved into int_lib.h, which would avoid the duplication.

[majnemer]

lib/builtins/int_util.h

22–28

Why are these macros underscore prefixed? I don't think we should invade the implementor's namespace here.

[angelsl]

Corrections made.

[aaron.ballman]

lib/builtins/int_lib.h

47

Please model this macro after LLVM_ATTRIBUTE_NORETURN from Compiler.h. It makes the usage far less ugly.

[angelsl]

Corrections made.

Didn't know that attributes could go before the declaration.

[compnerd]

lib/builtins/int_lib.h

38

This should be:

#if defined(__arm__) && defined(_WIN32) && !(defined(_MSC_VER) && defined(__clang__))

[angelsl]

Corrections made.

[compnerd]

SVN r249375.

lib/builtins/extendhfsf2.c

 #define DST_SINGLE
 #include "fp_extend_impl.inc"
 
+#ifdef _MSC_VER
+#define __NOINLINE __declspec(noinline)
+#else
+#define __NOINLINE __attribute__((noinline))
+#endif
+
 // Use a forwarding definition and noinline to implement a poor man's alias,
 // as there isn't a good cross-platform way of defining one.
-COMPILER_RT_ABI __attribute__((noinline)) float __extendhfsf2(uint16_t a) {
+COMPILER_RT_ABI __NOINLINE float __extendhfsf2(uint16_t a) {
     return __extendXfYf2__(a);
 }
 

lib/builtins/int_lib.h

 # define COMPILER_RT_ABI __attribute__((pcs("aapcs")))
 #else
 # define ARM_EABI_FNALIAS(aeabi_name, name)
-# if defined(__arm__) && defined(_WIN32)
+# if defined(__arm__) && defined(_WIN32) && !defined(_MSC_VER)
 #   define COMPILER_RT_ABI __attribute__((pcs("aapcs")))
 # else
 #   define COMPILER_RT_ABI

lib/builtins/int_util.h

 #ifndef INT_UTIL_H
 #define INT_UTIL_H
 
+#ifdef _MSC_VER
+#define __NORETURN(x) __declspec(noreturn) x
+#define __UNUSED
+#else
+#define __NORETURN(x) x __attribute__((noreturn))
+#define __UNUSED __attribute__((unused))
+#endif
+
 /** \brief Trigger a program abort (or panic for kernel code). */
 #define compilerrt_abort() compilerrt_abort_impl(__FILE__, __LINE__, \
                                                  __func__)
 
-void compilerrt_abort_impl(const char *file, int line,
-                           const char *function) __attribute__((noreturn));
+__NORETURN(void compilerrt_abort_impl(const char *file, int line,
+                           const char *function));
 
 #define COMPILE_TIME_ASSERT(expr) COMPILE_TIME_ASSERT1(expr, __COUNTER__)
 #define COMPILE_TIME_ASSERT1(expr, cnt) COMPILE_TIME_ASSERT2(expr, cnt)
 #define COMPILE_TIME_ASSERT2(expr, cnt) \
-    typedef char ct_assert_##cnt[(expr) ? 1 : -1] __attribute__((unused))
+    typedef char ct_assert_##cnt[(expr) ? 1 : -1] __UNUSED
 
 #endif /* INT_UTIL_H */

lib/builtins/truncsfhf2.c

 #define DST_HALF
 #include "fp_trunc_impl.inc"
 
+#ifdef _MSC_VER
+#define __NOINLINE __declspec(noinline)
+#else
+#define __NOINLINE __attribute__((noinline))
+#endif
+
 // Use a forwarding definition and noinline to implement a poor man's alias,
 // as there isn't a good cross-platform way of defining one.
-COMPILER_RT_ABI __attribute__((noinline)) uint16_t __truncsfhf2(float a) {
+COMPILER_RT_ABI __NOINLINE uint16_t __truncsfhf2(float a) {
     return __truncXfYf2__(a);
 }