This is an archive of the discontinued LLVM Phabricator instance.

Differential D134040

Remove sqrt and rsqrt related files from clspv libclc target SOURCES
ClosedPublic

Authored by aarongreig on Sep 16 2022, 6:31 AM.

Details

Reviewers
rjodinchr
kpet
Summary

As of https://github.com/google/clspv/pull/917 clspv now handles these builtins internally so they can be removed from the builtins library.

This contribution is being made by Codeplay on behalf of Samsung.

Diff Detail

Event Timeline

aarongreig created this revision.Sep 16 2022, 6:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 6:31 AM
Herald added a subscriber: jvesely. · View Herald Transcript
aarongreig requested review of this revision.Sep 16 2022, 6:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 6:31 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
rjodinchr accepted this revision.Sep 16 2022, 6:41 AM
This revision is now accepted and ready to land.Sep 16 2022, 6:41 AM
Harbormaster completed remote builds in B187127: Diff 460726.Sep 16 2022, 7:14 AM
aarongreig edited the summary of this revision. (Show Details)Oct 26 2022, 9:24 AM
aarongreig added a reviewer: kpet.Dec 13 2022, 6:25 AM
kpet mentioned this in rGf11ab8353f97: libclc: remove sqrt/rsqrt from clspv SOURCES.Feb 13 2023, 1:25 PM
kpet closed this revision.Feb 13 2023, 1:28 PM

Landed as f11ab8353f972647f276b07c24d1308859fbde0d.

Revision Contents

PathSize
libclc/
clspv/
lib/
3 lines

Diff 460726

libclc/clspv/lib/SOURCES

Context not available.
../../generic/lib/math/clc_remainder.cl ../../generic/lib/math/clc_remainder.cl
../../generic/lib/math/clc_remquo.cl ../../generic/lib/math/clc_remquo.cl
../../generic/lib/math/clc_rootn.cl ../../generic/lib/math/clc_rootn.cl
../../generic/lib/math/clc_sqrt.cl
../../generic/lib/math/clc_tan.cl ../../generic/lib/math/clc_tan.cl
../../generic/lib/math/erf.cl ../../generic/lib/math/erf.cl
../../generic/lib/math/erfc.cl ../../generic/lib/math/erfc.cl
Context not available.
../../generic/lib/math/remainder.cl ../../generic/lib/math/remainder.cl
../../generic/lib/math/remquo.cl ../../generic/lib/math/remquo.cl
../../generic/lib/math/rootn.cl ../../generic/lib/math/rootn.cl
../../generic/lib/math/rsqrt.cl
../../generic/lib/math/sqrt.cl
../../generic/lib/math/tables.cl ../../generic/lib/math/tables.cl
../../generic/lib/math/tanh.cl ../../generic/lib/math/tanh.cl
../../generic/lib/math/tgamma.cl ../../generic/lib/math/tgamma.cl
Context not available.