[lldb] Fix parentheses placement in GetExpressionPath

[kastiglione]

Summary

Adjust the placement of parentheses around a pointer dereference in
GetExpressionPath.

The comment states:

*(a_ptr).memberName, which is entirely fine

but the expression should be: (*a_ptr).memberName.

[kastiglione]

I noticed this when running v *SomeVar and the variable contained a llvm::PointerUnion. The synthetic provider for PointerUnion uses GetExpressionPath.

[kastiglione]

This was already being worked on in D132734 by @tonkosi

lldb/source/Core/ValueObject.cpp

if (m_flags.m_is_synthetic_children_generated) {
     return;
   }
 
   const bool is_deref_of_parent = IsDereferenceOfParent();
 
   if (is_deref_of_parent &&
       epformat == eGetExpressionPathFormatDereferencePointers) {
     // this is the original format of GetExpressionPath() producing code like
-    // *(a_ptr).memberName, which is entirely fine, until you put this into
+    // (*a_ptr).memberName, which is entirely fine, until you put this into
     // StackFrame::GetValueForVariableExpressionPath() which prefers to see
     // a_ptr->memberName. the eHonorPointers mode is meant to produce strings
     // in this latter format
-    s.PutCString("*(");
+    s.PutCString("(*");
   }
 
   ValueObject *parent = GetParent();
 
   if (parent)
     parent->GetExpressionPath(s, epformat);
 
   // if we are a deref_of_parent just because we are synthetic array members

lldb/test/API/python_api/exprpath_synthetic/main.mm

 #import <Foundation/Foundation.h>
 #include <vector>
 
 int main (int argc, char const *argv[])
 {
     std::vector<int> v{1,2,3,4,5};
     NSArray *a = @[@"Hello",@"World",@"From Me"];
+    int *p;
     return 0; //% v = self.frame().FindVariable("v"); v0 = v.GetChildAtIndex(0); s = lldb.SBStream(); v0.GetExpressionPath(s);
     //% self.runCmd("expr %s = 12" % s.GetData()); self.assertTrue(v0.GetValueAsUnsigned() == 12, "value change via expr failed")
     //% a = self.frame().FindVariable("a"); a1 = a.GetChildAtIndex(1); s = lldb.SBStream(); a1.GetExpressionPath(s);
     //% self.expect("po %s" % s.GetData(), substrs = ["World"])
+    //% p = self.frame().GetValueForVariablePath("*p")
+    //% self.assertEqual(p.path, "(*p)")
 }