This is an archive of the discontinued LLVM Phabricator instance.

Differential D133796

[libc++][chrono] Removes format include.
ClosedPublic

Authored by Mordante on Sep 13 2022, 11:28 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGf2a263512c83: [libc++][chrono] Removes format include.
Summary

Switch to the new granular format_functions header. Since the chrono's
format dependency in C++20 hasn't been in a release it's save to remove
it.

Depends on D133665

Diff Detail

Unit TestsFailed

TimeTest
1,500,900 mslibcxx CI MacOS arm64 > llvm-libc++-shared-cfg-in.std/algorithms/alg_modifying_operations/alg_transform::ranges.transform.pass.cpp

Event Timeline

Mordante created this revision.Sep 13 2022, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 11:28 AM
Mordante requested review of this revision.Sep 13 2022, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 11:28 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B186420: Diff 459823.Sep 13 2022, 1:18 PM
ldionne accepted this revision.Sep 14 2022, 2:04 PM
This revision is now accepted and ready to land.Sep 14 2022, 2:04 PM
This revision was landed with ongoing or failed builds.Sep 20 2022, 9:58 AM
Closed by commit rGf2a263512c83: [libc++][chrono] Removes format include. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGf2a263512c83: [libc++][chrono] Removes format include..

Revision Contents

PathSize
libcxx/
include/
__chrono/
2 lines
test/
libcxx/
transitive_includes/
cxx20/
1 line
cxx2b/
1 line

Diff 459823

libcxx/include/__chrono/ostream.h

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___CHRONO_OSTREAM_H #ifndef _LIBCPP___CHRONO_OSTREAM_H
#define _LIBCPP___CHRONO_OSTREAM_H #define _LIBCPP___CHRONO_OSTREAM_H
#include <__chrono/day.h> #include <__chrono/day.h>
#include <__chrono/statically_widen.h> #include <__chrono/statically_widen.h>
#include <__config> #include <__config>
#include <format> #include <__format/format_functions.h>
#include <ostream> #include <ostream>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
Show All 25 Lines

libcxx/test/libcxx/transitive_includes/cxx20/expected.chrono

Show All 14 Lines
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
exception exception
format
functional functional
initializer_list initializer_list
ios ios
iosfwd iosfwd
istream istream
iterator iterator
limits limits
locale locale
Show All 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.chrono

Show All 12 Lines
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
exception exception
format
initializer_list initializer_list
ios ios
iosfwd iosfwd
istream istream
limits limits
locale locale
mutex mutex
new new
Show All 13 Lines