This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer_common] Restore sanitizer_procmaps_solaris.cpp compilation on Solaris 11.3
ClosedPublic

Authored by ro on Sep 9 2022, 1:17 AM.

Details

Summary

When upstream compiler-rt was recently imported into GCC's libsanitizer, Solaris 11.3 bootstrap broke because in 11.3 <sys/procfs.h> doesn't mix with largefile compilation. I'd caused this in D129837 where I forgot that the code still needs to support Solaris 11.3.

Fixed by restoring the #undef _FILE_OFFSET_BITS.

Tested on sparc-sun-solaris2.11 and amd64-pc-solaris2.11 (Solaris 11.4) in LLVM and both Solaris 11.3 and 11.4 in GCC.

Diff Detail

Event Timeline

ro created this revision.Sep 9 2022, 1:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2022, 1:17 AM
ro requested review of this revision.Sep 9 2022, 1:17 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptSep 9 2022, 1:17 AM
ro added a comment.Sep 20 2022, 7:29 AM

Ping? It's been a weed and a half.

vitalybuka accepted this revision.Sep 22 2022, 1:15 PM

Sorry for delay.

This revision is now accepted and ready to land.Sep 22 2022, 1:15 PM
ro added a comment.Sep 23 2022, 6:51 AM

No worries: I could easily keep the patch local to gcc for a while, and LLVM isn't affected anyway (apart from the staging buildmaster being down for more than a week).