[lldb][fuzz] Allow expression fuzzer to be passed as a flag.

[rupprecht]

Summary

The expression fuzzer checks an environment variable, LLDB_FUZZER_TARGET, to get the fuzzer target binary. This is fine, but internally our tooling for running fuzz tests only has proper handling for flag values. It's surprisingly complicated to add support for that, and allowing it to be passed via flag seems reasonable anyway.

[cassanova]

lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp

65–67

I think having a flag for the fuzzer target alongside the env variable is a good addition. My only wonder is if there should be an error message if no flag is specified so that anyone that uses this knows that they can use a flag as well.

[rupprecht]

• Update error message to reference the new command line flag

[rupprecht]

lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp

65–67

That makes sense -- let me know if the updated wording looks OK.

[cassanova]

The wording is good, LGTM!

lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp

 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/FormatVariadic.h"
 #include "llvm/Support/WithColor.h"
 
 using namespace lldb;
 using namespace llvm;
 using namespace clang_fuzzer;
 
-char *target_path;
+const char *target_path = nullptr;
 
 void ReportError(llvm::StringRef message) {
   WithColor::error() << message << '\n';
   exit(1);
 }
 
 extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) {
 #if !defined(_WIN32)
   signal(SIGPIPE, SIG_IGN);
 #endif
 
+  // `target_path` can be set by either the "--lldb_fuzzer_target" commandline
+  // flag or the "LLDB_FUZZER_TARGET" environment variable. Arbitrarily, we
+  // always do flag parsing and only check the environment variable if the
+  // commandline flag is not set.
+  for (int i = 1; i < *argc; ++i) {
+    auto this_arg = llvm::StringRef((*argv)[i]);
+    WithColor::note() << "argv[" << i << "] = " << this_arg << "\n";
+    if (this_arg.consume_front("--lldb_fuzzer_target="))
+      target_path = this_arg.data();
+  }
+
+  if (!target_path)
     target_path = ::getenv("LLDB_FUZZER_TARGET");
+
   if (!target_path)
-    ReportError(
-        "no target path specified in with the LLDB_FUZZER_TARGET variable");
+    ReportError("No target path specified. Set one either as an environment "
+                "variable (i.e. LLDB_FUZZER_TARGET=target_path) or pass as a "
+                "command line flag (i.e. --lldb_fuzzer_target=target_path).");
 
   if (!sys::fs::exists(target_path))
     ReportError(formatv("target path '{0}' does not exist", target_path).str());
 
   SBDebugger::Initialize();
 
   return 0;
 }