This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Make the `rumtimes` target a test dependency
ClosedPublic

Authored by JDevlieghere on Aug 31 2022, 1:21 PM.

Details

Summary

Make the rumtimes target a test dependency

Diff Detail

Event Timeline

JDevlieghere created this revision.Aug 31 2022, 1:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 1:21 PM
Herald added a subscriber: mgorny. · View Herald Transcript
JDevlieghere requested review of this revision.Aug 31 2022, 1:21 PM
fdeazeve accepted this revision.Aug 31 2022, 1:33 PM

LGTM!

This revision is now accepted and ready to land.Aug 31 2022, 1:33 PM
jingham accepted this revision.Aug 31 2022, 2:05 PM

This is needed or the parts of the lldb testsuite that rely on the libcxx & libcxxabi will fail when you do ninja check-lldb. Thanks for fixing this.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 2:25 PM