This is an archive of the discontinued LLVM Phabricator instance.

In D133022#3761459, @corona10 wrote:

FYI, I don't have the commit bit.
So you may need my information to land this CL :)
Github name: corona10
email: donghee.na92@gmail.com

Thanks! Will commit this shortly.

Closed by commit rGe75cce76ab86: [libc] Fix typo in lseek syscall number macro. (authored by corona10, committed by sivachandra). · Explain WhyAug 31 2022, 10:58 AM

This revision was automatically updated to reflect the committed changes.

sivachandra added a commit: rGe75cce76ab86: [libc] Fix typo in lseek syscall number macro..

sivachandra mentioned this in D129963: [libc] use correct syscall define for SYS__llseek.Nov 16 2022, 10:27 PM

Revision Contents

Path

Size

libc/

src/

__support/

File/

linux_file.cpp

2 lines

unistd/

linux/

lseek.cpp

4 lines

Diff 457024

libc/src/__support/File/linux_file.cpp

	Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines
	}			}

	int seek_func(File *f, long offset, int whence) {			int seek_func(File *f, long offset, int whence) {
	auto lf = reinterpret_cast<LinuxFile >(f);			auto lf = reinterpret_cast<LinuxFile >(f);
	#ifdef SYS_lseek			#ifdef SYS_lseek
	long ret = __llvm_libc::syscall(SYS_lseek, lf->get_fd(), offset, whence);			long ret = __llvm_libc::syscall(SYS_lseek, lf->get_fd(), offset, whence);
	#elif defined(SYS__llseek)			#elif defined(SYS__llseek)
	long result;			long result;
	long ret = __llvm_libc::syscall(SYS__lseek, lf->get_fd(), offset >> 32,			long ret = __llvm_libc::syscall(SYS__llseek, lf->get_fd(), offset >> 32,
	offset, &result, whence);			offset, &result, whence);
	#else			#else
	#error "lseek and _llseek syscalls not available to perform a seek operation."			#error "lseek and _llseek syscalls not available to perform a seek operation."
	#endif			#endif

	if (ret < 0) {			if (ret < 0) {
	errno = -ret;			errno = -ret;
	return -1;			return -1;
	▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines

libc/src/unistd/linux/lseek.cpp

	Show All 17 Lines
	namespace __llvm_libc {			namespace __llvm_libc {

	LLVM_LIBC_FUNCTION(off_t, lseek, (int fd, off_t offset, int whence)) {			LLVM_LIBC_FUNCTION(off_t, lseek, (int fd, off_t offset, int whence)) {
	off_t result;			off_t result;
	#ifdef SYS_lseek			#ifdef SYS_lseek
	long ret = __llvm_libc::syscall(SYS_lseek, fd, offset, whence);			long ret = __llvm_libc::syscall(SYS_lseek, fd, offset, whence);
	result = ret;			result = ret;
	#elif defined(SYS__llseek)			#elif defined(SYS__llseek)
	long ret = __llvm_libc::syscall(SYS__lseek, fd, offset >> 32, offset, &result,			long ret = __llvm_libc::syscall(SYS__llseek, fd, offset >> 32, offset,
	whence);			&result, whence);
	#else			#else
	#error "lseek and _llseek syscalls not available."			#error "lseek and _llseek syscalls not available."
	#endif			#endif

	if (ret < 0) {			if (ret < 0) {
	errno = -ret;			errno = -ret;
	return -1;			return -1;
	}			}
	return result;			return result;
	}			}

	} // namespace __llvm_libc			} // namespace __llvm_libc

This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix seek_func to use SYS__llseek if possibleClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 457024

libc/src/__support/File/linux_file.cpp

libc/src/unistd/linux/lseek.cpp

[libc] Fix seek_func to use SYS__llseek if possible
ClosedPublic