This is an archive of the discontinued LLVM Phabricator instance.

Differential D132362

Add clspv to libclc targets exempt from alwaysinline
ClosedPublic

Authored by aarongreig on Aug 22 2022, 2:55 AM.

Details

Reviewers
kpet
rjodinchr
Summary

Like the other SPIR-V targets clspv performs optimizations on the code it gets from libclc after linking, and it also stands to benefit from being able to choose which functions get inlined.

This contribution is being made by Codeplay on behalf of Samsung.

Diff Detail

Event Timeline

aarongreig created this revision.Aug 22 2022, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2022, 2:55 AM
Herald added a subscriber: jvesely. · View Herald Transcript
aarongreig requested review of this revision.Aug 22 2022, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2022, 2:55 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B182539: Diff 454049.Aug 22 2022, 3:14 AM
jlewis-austin added a subscriber: jlewis-austin.Aug 25 2022, 8:06 AM
aarongreig added reviewers: kpet, rjodinchr.Dec 13 2022, 6:25 AM
rjodinchr accepted this revision.Dec 13 2022, 6:26 AM
This revision is now accepted and ready to land.Dec 13 2022, 6:26 AM
kpet mentioned this in rG1da2085a5133: libclc: add clspv to targets exempt from alwaysinline.Feb 14 2023, 10:24 AM
kpet closed this revision.Feb 14 2023, 10:25 AM

Landed as 1da2085a513341f0e8d7578415dcf77d614708e5.

Revision Contents

PathSize
libclc/
generic/
include/
clc/
6 lines

Diff 454049

libclc/generic/include/clc/clcfunc.h

#define _CLC_OVERLOAD __attribute__((overloadable)) #define _CLC_OVERLOAD __attribute__((overloadable))
#define _CLC_DECL #define _CLC_DECL
#define _CLC_INLINE __attribute__((always_inline)) inline #define _CLC_INLINE __attribute__((always_inline)) inline
/* avoid inlines for SPIR-V since we'll optimise later in the chain */ // avoid inlines for SPIR-V related targets since we'll optimise later in the
#if defined(CLC_SPIRV) || defined(CLC_SPIRV64) // chain
#if defined(CLC_SPIRV) || defined(CLC_SPIRV64) || defined(CLC_CLSPV) || \
defined(CLC_CLSPV64)
#define _CLC_DEF #define _CLC_DEF
#else #else
#define _CLC_DEF __attribute__((always_inline)) #define _CLC_DEF __attribute__((always_inline))
#endif #endif