[lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

[Michael137]

Summary

This test fails for Clang versions < 14.0 for dsym variants.
dsymutil strips debug info for classes with only static members.
Thus move the failing assertions into the XFAIL test case.

[aprantl]

This might be a bit aggressive. If it's easy we could add a if clang > 14 condition before those last two tests so we don't loose coverage?

[Michael137]

• Make XFAIL more specific

[Michael137]

In D132004#3727682, @aprantl wrote:

This might be a bit aggressive. If it's easy we could add a if clang > 14 condition before those last two tests so we don't loose coverage?

Fair point, I moved the assertions to a new XFAIL test-case which is specific to dsym Clang 14.0 variants

[fdeazeve]

This test is now failing even on the "basic" Clang (i.e. tip of trunk) test matrix entry:

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/?consoleFull

The log above is for the "Test DWARF4" portion of the job

[Michael137]

In D132004#3728394, @fdeazeve wrote:

This test is now failing even on the "basic" Clang (i.e. tip of trunk) test matrix entry:

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/?consoleFull

The log above is for the "Test DWARF4" portion of the job

That's very confusing, will have to check what the debug info looks like on the machines

[Michael137]

Build bot is green for ToT. Should be safe to commit this

[fdeazeve]

In D132004#3728394, @fdeazeve wrote:

This test is now failing even on the "basic" Clang (i.e. tip of trunk) test matrix entry:

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/?consoleFull

The log above is for the "Test DWARF4" portion of the job

Looking at the logs, the Dwarf 2 and Dwarf 4 jobs do not use ToT, but rather Clang 13. For example, for the Dwarf 2 job, we see this:

"/Users/buildslave/jenkins/workspace/lldb-cmake-matrix/clang_1300_build/bin/clang" -std=c++11 -gdwarf-2 -isysroot

Which is weird, given how we don't build Clang 13 until much later on the pipeline.
I think the bot has a polluted environment somehow across runs. For example, build 5042:

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5042/execution/node/52/log/?consoleFull

ERROR:root:/Users/buildslave/jenkins/workspace/lldb-cmake-matrix/clang_1300_build/bin/clang is not a valid compiler executable; aborting...

Sometimes the Clang13 builds get cleaned up (see how sometimes the Clang 13 jobs take 30s to run, and sometimes 40min).
I'm guessing that this error shows up when the previous build got cleaned up.

[Michael137]

In D132004#3728652, @fdeazeve wrote:

In D132004#3728394, @fdeazeve wrote:

This test is now failing even on the "basic" Clang (i.e. tip of trunk) test matrix entry:

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5043/execution/node/62/log/?consoleFull

The log above is for the "Test DWARF4" portion of the job

Looking at the logs, the Dwarf 2 and Dwarf 4 jobs do not use ToT, but rather Clang 13. For example, for the Dwarf 2 job, we see this:

"/Users/buildslave/jenkins/workspace/lldb-cmake-matrix/clang_1300_build/bin/clang" -std=c++11 -gdwarf-2 -isysroot

Which is weird, given how we don't build Clang 13 until much later on the pipeline.
I think the bot has a polluted environment somehow across runs. For example, build 5042:

https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/5042/execution/node/52/log/?consoleFull

ERROR:root:/Users/buildslave/jenkins/workspace/lldb-cmake-matrix/clang_1300_build/bin/clang is not a valid compiler executable; aborting...

Sometimes the Clang13 builds get cleaned up (see how sometimes the Clang 13 jobs take 30s to run, and sometimes 40min).
I'm guessing that this error shows up when the previous build got cleaned up.

Yup that would explain why this sometimes passes (only the times where we use top-of-tree clang). Confident now that this change will fix the Clang < 14.0 tests.

[fdeazeve]

Greendragon is leaking environment configurations across runs. I'll address this in a separate PR

lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py

def test(self):
         self.expect_expr("A::not_enumerator_scoped_enum_val_2",
                          result_value="scoped_enum_case1 | scoped_enum_case2 | 0x4")
 
         # Test an enum with fixed underlying type.
         self.expect_expr("A::scoped_char_enum_val", result_value="case2")
         self.expect_expr("A::scoped_ll_enum_val_neg", result_value="case0")
         self.expect_expr("A::scoped_ll_enum_val", result_value="case2")
 
-        # Test an aliased enum with fixed underlying type.
-        self.expect_expr("ClassWithEnumAlias::enum_alias",
-                         result_value="scoped_enum_case2")
-        self.expect_expr("ClassWithEnumAlias::enum_alias_alias",
-                         result_value="scoped_enum_case1")
-
         # Test taking address.
         if lldbplatformutil.getPlatform() == "windows":
             # On Windows data members without the out-of-class definitions still have
             # valid adresses and the following expression works fine.
             self.expect_expr("const int *i = &A::int_val; *i", result_value="1")
         else:
             # On other platforms (Linux, macos) data members without the out-of-class
             # definitions don't have valid addresses and the following code produces
class TestCase(TestBase):
     # data members without a definition namespace scope.
     @expectedFailureAll(debug_info=["dsym"])
     def test_class_with_only_const_static(self):
         self.build()
         lldbutil.run_to_source_breakpoint(self, "// break here", lldb.SBFileSpec("main.cpp"))
 
         self.expect_expr("ClassWithOnlyConstStatic::member", result_value="3")
 
+    # With older versions of Clang, LLDB fails to evaluate classes with only
+    # constexpr members when dsymutil is enabled
+    @expectedFailureAll(debug_info=["dsym"], compiler=["clang"], compiler_version=["<", "14.0"])
+    def test_class_with_only_constexpr_static(self):
+        self.build()
+        lldbutil.run_to_source_breakpoint(self, "// break here", lldb.SBFileSpec("main.cpp"))
+
         # Test `constexpr static`.
         self.expect_expr("ClassWithConstexprs::member", result_value="2")
         self.expect_expr("ClassWithConstexprs::enum_val", result_value="enum_case2")
         self.expect_expr("ClassWithConstexprs::scoped_enum_val", result_value="scoped_enum_case2")
+
+        # Test an aliased enum with fixed underlying type.
+        self.expect_expr("ClassWithEnumAlias::enum_alias",
+                         result_value="scoped_enum_case2")
+        self.expect_expr("ClassWithEnumAlias::enum_alias_alias",
+                         result_value="scoped_enum_case1")